RESOLVED FIXED 209813
Remove <br> render tree dump quirk 
https://bugs.webkit.org/show_bug.cgi?id=209813
Summary Remove <br> render tree dump quirk
Antti Koivisto
Reported 2020-03-31 09:16:41 PDT
Stop lying about <br> size and position in render tree dumps.
Attachments
wip (828.04 KB, patch)
2020-03-31 10:00 PDT, Antti Koivisto 		no flags
DetailsFormatted DiffDiff
plain patch without rebasing (6.75 KB, patch)
2020-09-29 05:38 PDT, Antti Koivisto 		zalan: review+
ews-feeder: commit-queue-
DetailsFormatted DiffDiff
generate all test results (3.37 KB, patch)
2020-10-14 08:03 PDT, Antti Koivisto 		ews-feeder: commit-queue-
DetailsFormatted DiffDiff
for bots (1.51 MB, patch)
2020-10-14 09:31 PDT, Antti Koivisto 		no flags
DetailsFormatted DiffDiff
for bots (2.14 MB, patch)
2020-10-14 10:26 PDT, Antti Koivisto 		ews-feeder: commit-queue-
DetailsFormatted DiffDiff
for bots (3.91 MB, patch)
2020-10-15 00:08 PDT, Antti Koivisto 		ews-feeder: commit-queue-
DetailsFormatted DiffDiff
for bots (4.41 MB, patch)
2020-10-15 01:35 PDT, Antti Koivisto 		no flags
DetailsFormatted DiffDiff
patch (4.52 MB, patch)
2020-10-15 02:58 PDT, Antti Koivisto 		no flags
DetailsFormatted DiffDiff
Show Obsolete (6) View All Add attachment proposed patch, testcase, etc.
Antti Koivisto
Comment 1 2020-03-31 10:00:08 PDT
Created attachment 395056 [details] wip
zalan
Comment 2 2020-03-31 10:01:34 PDT
so much bravery here
Antti Koivisto
Comment 3 2020-09-29 05:38:35 PDT
Created attachment 409987 [details] plain patch without rebasing
Antti Koivisto
Comment 4 2020-09-29 09:04:43 PDT
This will require lots of rebasing to land.
Antti Koivisto
Comment 5 2020-10-14 08:03:43 PDT
Created attachment 411323 [details] generate all test results
Jonathan Bedard
Comment 6 2020-10-14 09:10:46 PDT
Let's include bot watchers on this one, this sort of change makes bisection difficult.
Antti Koivisto
Comment 7 2020-10-14 09:31:17 PDT
Created attachment 411332 [details] for bots
Antti Koivisto
Comment 8 2020-10-14 10:26:03 PDT
Created attachment 411346 [details] for bots
Antti Koivisto
Comment 9 2020-10-15 00:08:28 PDT
Created attachment 411413 [details] for bots
Antti Koivisto
Comment 10 2020-10-15 01:35:24 PDT
Created attachment 411418 [details] for bots
Antti Koivisto
Comment 11 2020-10-15 02:58:52 PDT
Created attachment 411420 [details] patch
EWS
Comment 12 2020-10-15 04:32:45 PDT
Committed r268520: <https://trac.webkit.org/changeset/268520> All reviewed patches have been landed. Closing bug and clearing flags on attachment 411420 [details].
Radar WebKit Bug Importer
Comment 13 2020-10-15 04:33:20 PDT
<rdar://problem/70331086>
Antti Koivisto
Comment 14 2020-10-15 04:45:48 PDT
Botwatchers, any fallout from this can be handled by rebasing.
Truitt Savell
Comment 15 2020-10-15 15:00:31 PDT
Rebaslined tests for Catalina in: https://trac.webkit.org/changeset/268556/webkit
Carlos Alberto Lopez Perez
Comment 16 2020-10-15 18:31:48 PDT
Rebaselined tests for GTK in r268545 and for WPE in r268568
Truitt Savell
Comment 17 2020-10-16 16:50:27 PDT
Rebaslined tests for Big Sur https://trac.webkit.org/changeset/268620/webkit
Ryan Haddad
Comment 18 2020-10-16 18:04:33 PDT
Reverted r268620 for reason: Breaks tests for Catalina and Mojave Committed r268625: <https://trac.webkit.org/changeset/268625>
Darin Adler
Comment 19 2020-10-18 16:43:59 PDT
When I run tests locally, I see failures that seem to be related to this. So it seems like we haven’t done enough rebasing yet. Here are some tests that are failing locally for me due to <br> geometry differences: editing/selection/3690703-2.html editing/selection/3690703.html editing/selection/3690719.html fast/css/rtl-ordering.html fast/forms/input-appearance-spinbutton.html There are probably more; these are mixed in with failures caused by the code I am working on. I am running modern WebKit tests on a Mac running macOS Big Sur.
Karl Rackler
Comment 20 2020-10-20 18:07:20 PDT
Re-baseline test for Big Sur after the changes in r268750 https://trac.webkit.org/changeset/268777/webkit
Note You need to log in before you can comment on or make changes to this bug.