Bug 209813 - Remove <br> render tree dump quirk
Summary: Remove <br> render tree dump quirk
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Layout and Rendering (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2020-03-31 09:16 PDT by Antti Koivisto
Modified: 2020-10-20 18:07 PDT (History)
21 users (show)

See Also:

Attachments
wip (828.04 KB, patch)
2020-03-31 10:00 PDT, Antti Koivisto 		no flags Details | Formatted Diff | Diff
plain patch without rebasing (6.75 KB, patch)
2020-09-29 05:38 PDT, Antti Koivisto 		zalan: review+
ews-feeder: commit-queue-
Details | Formatted Diff | Diff
generate all test results (3.37 KB, patch)
2020-10-14 08:03 PDT, Antti Koivisto 		ews-feeder: commit-queue-
Details | Formatted Diff | Diff
for bots (1.51 MB, patch)
2020-10-14 09:31 PDT, Antti Koivisto 		no flags Details | Formatted Diff | Diff
for bots (2.14 MB, patch)
2020-10-14 10:26 PDT, Antti Koivisto 		ews-feeder: commit-queue-
Details | Formatted Diff | Diff
for bots (3.91 MB, patch)
2020-10-15 00:08 PDT, Antti Koivisto 		ews-feeder: commit-queue-
Details | Formatted Diff | Diff
for bots (4.41 MB, patch)
2020-10-15 01:35 PDT, Antti Koivisto 		no flags Details | Formatted Diff | Diff
patch (4.52 MB, patch)
2020-10-15 02:58 PDT, Antti Koivisto 		no flags Details | Formatted Diff | Diff
Show Obsolete (6) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Antti Koivisto 2020-03-31 09:16:41 PDT 
Stop lying about <br> size and position in render tree dumps.
Comment 1 Antti Koivisto 2020-03-31 10:00:08 PDT 
Created attachment 395056 [details]
wip
Comment 2 zalan 2020-03-31 10:01:34 PDT 
so much bravery here
Comment 3 Antti Koivisto 2020-09-29 05:38:35 PDT 
Created attachment 409987 [details]
plain patch without rebasing
Comment 4 Antti Koivisto 2020-09-29 09:04:43 PDT 
This will require lots of rebasing to land.
Comment 5 Antti Koivisto 2020-10-14 08:03:43 PDT 
Created attachment 411323 [details]
generate all test results
Comment 6 Jonathan Bedard 2020-10-14 09:10:46 PDT 
Let's include bot watchers on this one, this sort of change makes bisection difficult.
Comment 7 Antti Koivisto 2020-10-14 09:31:17 PDT 
Created attachment 411332 [details]
for bots
Comment 8 Antti Koivisto 2020-10-14 10:26:03 PDT 
Created attachment 411346 [details]
for bots
Comment 9 Antti Koivisto 2020-10-15 00:08:28 PDT 
Created attachment 411413 [details]
for bots
Comment 10 Antti Koivisto 2020-10-15 01:35:24 PDT 
Created attachment 411418 [details]
for bots
Comment 11 Antti Koivisto 2020-10-15 02:58:52 PDT 
Created attachment 411420 [details]
patch
Comment 12 EWS 2020-10-15 04:32:45 PDT 
Committed r268520: <https://trac.webkit.org/changeset/268520>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 411420 [details].
Comment 13 Radar WebKit Bug Importer 2020-10-15 04:33:20 PDT 
<rdar://problem/70331086>
Comment 14 Antti Koivisto 2020-10-15 04:45:48 PDT 
Botwatchers, any fallout from this can be handled by rebasing.
Comment 15 Truitt Savell 2020-10-15 15:00:31 PDT 
Rebaslined tests for Catalina in: https://trac.webkit.org/changeset/268556/webkit
Comment 16 Carlos Alberto Lopez Perez 2020-10-15 18:31:48 PDT 
Rebaselined tests for GTK in r268545 and for WPE in r268568
Comment 17 Truitt Savell 2020-10-16 16:50:27 PDT 
Rebaslined tests for Big Sur https://trac.webkit.org/changeset/268620/webkit
Comment 18 Ryan Haddad 2020-10-16 18:04:33 PDT 
Reverted r268620 for reason:

Breaks tests for Catalina and Mojave

Committed r268625: <https://trac.webkit.org/changeset/268625>
Comment 19 Darin Adler 2020-10-18 16:43:59 PDT 
When I run tests locally, I see failures that seem to be related to this. So it seems like we haven’t done enough rebasing yet.

Here are some tests that are failing locally for me due to <br> geometry differences:

editing/selection/3690703-2.html
editing/selection/3690703.html
editing/selection/3690719.html
fast/css/rtl-ordering.html
fast/forms/input-appearance-spinbutton.html

There are probably more; these are mixed in with failures caused by the code I am working on. I am running modern WebKit tests on a Mac running macOS Big Sur.
Comment 20 Karl Rackler 2020-10-20 18:07:20 PDT 
Re-baseline test for Big Sur after the changes in r268750
https://trac.webkit.org/changeset/268777/webkit