Bug 209808 - Support resolution of IPv6 STUN/TURN addresses
Summary: Support resolution of IPv6 STUN/TURN addresses
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebRTC (show other bugs)
Version: WebKit Local Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: youenn fablet
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2020-03-31 07:22 PDT by youenn fablet
Modified: 2020-04-01 02:08 PDT (History)
8 users (show)

See Also:

Attachments
Patch (6.64 KB, patch)
2020-03-31 07:44 PDT, youenn fablet 		no flags Details | Formatted Diff | Diff
Patch (6.76 KB, patch)
2020-03-31 08:12 PDT, youenn fablet 		no flags Details | Formatted Diff | Diff
Patch for landing (8.16 KB, patch)
2020-04-01 00:04 PDT, youenn fablet 		no flags Details | Formatted Diff | Diff
Patch for landing (7.99 KB, patch)
2020-04-01 00:37 PDT, youenn fablet 		no flags Details | Formatted Diff | Diff
Patch for landing (10.25 KB, patch)
2020-04-01 00:58 PDT, youenn fablet 		no flags Details | Formatted Diff | Diff
Patch for landing (10.27 KB, patch)
2020-04-01 01:08 PDT, youenn fablet 		no flags Details | Formatted Diff | Diff
Patch for landing (10.28 KB, patch)
2020-04-01 01:23 PDT, youenn fablet 		no flags Details | Formatted Diff | Diff
Show Obsolete (6) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description youenn fablet 2020-03-31 07:22:17 PDT 
Support resolution of IPv6 STUN/TURN addresses
Comment 1 Radar WebKit Bug Importer 2020-03-31 07:42:03 PDT 
<rdar://problem/61106625>
Comment 2 youenn fablet 2020-03-31 07:44:13 PDT 
Created attachment 395036 [details]
Patch
Comment 3 youenn fablet 2020-03-31 08:12:11 PDT 
Created attachment 395041 [details]
Patch
Comment 4 youenn fablet 2020-03-31 09:32:03 PDT 
Comment on attachment 395041 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=395041&action=review

> Source/WebCore/platform/network/DNS.h:54
> +    struct sockaddr_in6 m_address;

It might be better to use a Variant<inet, inet6>, I'll switch to that before landing.
Comment 5 youenn fablet 2020-04-01 00:04:46 PDT 
Created attachment 395135 [details]
Patch for landing
Comment 6 youenn fablet 2020-04-01 00:37:42 PDT 
Created attachment 395138 [details]
Patch for landing
Comment 7 youenn fablet 2020-04-01 00:58:05 PDT 
Created attachment 395140 [details]
Patch for landing
Comment 8 youenn fablet 2020-04-01 01:08:54 PDT 
Created attachment 395141 [details]
Patch for landing
Comment 9 EWS 2020-04-01 01:14:14 PDT 
ChangeLog entry in Source/WebKit/ChangeLog contains OOPS!.
Comment 10 youenn fablet 2020-04-01 01:23:45 PDT 
Created attachment 395146 [details]
Patch for landing
Comment 11 youenn fablet 2020-04-01 01:24:51 PDT 
Added a FIXME for SOUP backend to handle multiple addresses, with potentially both IPv6 and IPv4 addresses.
Comment 12 EWS 2020-04-01 02:08:32 PDT 
Committed r259338: <https://trac.webkit.org/changeset/259338>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 395146 [details].