Bug 209795 - Add SPI WKWebpagePreferences._userContentController
Summary: Add SPI WKWebpagePreferences._userContentController
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Alex Christensen
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2020-03-30 21:47 PDT by Alex Christensen
Modified: 2020-03-31 13:15 PDT (History)
3 users (show)

See Also:


Attachments
Patch (77.71 KB, patch)
2020-03-30 21:54 PDT, Alex Christensen
no flags Details | Formatted Diff | Diff
Patch (77.58 KB, patch)
2020-03-30 22:04 PDT, Alex Christensen
no flags Details | Formatted Diff | Diff
Patch (75.04 KB, patch)
2020-03-31 09:05 PDT, Alex Christensen
timothy: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Alex Christensen 2020-03-30 21:47:01 PDT
Add SPI WKWebpagePreferences._userContentController
Comment 1 Alex Christensen 2020-03-30 21:54:25 PDT
Created attachment 395014 [details]
Patch
Comment 2 Alex Christensen 2020-03-30 22:04:50 PDT
Created attachment 395015 [details]
Patch
Comment 3 Alex Christensen 2020-03-31 09:02:03 PDT
Comment on attachment 395015 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=395015&action=review

> Source/WebKit/UIProcess/WebPageProxy.cpp:5304
> +        RELEASE_ASSERT(!policies);

This was too aggressive, and technically unrelated.  I'll remove this change.
Comment 4 Alex Christensen 2020-03-31 09:05:47 PDT
Created attachment 395044 [details]
Patch
Comment 5 Alex Christensen 2020-03-31 13:14:02 PDT
http://trac.webkit.org/r259307
Comment 6 Radar WebKit Bug Importer 2020-03-31 13:15:19 PDT
<rdar://problem/61121163>