Bug 209789 – [iPad] Use AVAudioSession to detect AirPlay route changes

• Status: RESOLVED
• Resolution: FIXED
• Component: Media

[Eric Carlson]

Use AVAudioSession to detect AirPlay route changes

[Eric Carlson]

<rdar://problem/58065279>

[Eric Carlson]

Created attachment 394989 [details]
Patch

[Eric Carlson]

Created attachment 395046 [details]
Patch

[Eric Carlson]

Created attachment 395055 [details]
Patch

[Jer Noble]

Comment on attachment 395055 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=395055&action=review

r=me with nits.

> Source/WebCore/platform/audio/ios/MediaSessionHelperIOS.mm:106
> +void activeAudioRouteDidChange(bool);
> +void activeVideoRouteDidChange();

Weird spacing here.

> Source/WebCore/platform/graphics/MediaPlaybackTarget.h:47
> +    virtual bool supportsAirPlayVideo() const = 0;

It's kind of weird to have the term "AirPlay" here in a cross-port header.  Could we change this to "supportsRemoteVideoPlayback" or something?

[Eric Carlson]

Comment on attachment 395055 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=395055&action=review

Thanks for the review!

>> Source/WebCore/platform/audio/ios/MediaSessionHelperIOS.mm:106
>> +void activeVideoRouteDidChange();
> 
> Weird spacing here.

Fixed.

>> Source/WebCore/platform/graphics/MediaPlaybackTarget.h:47
>> +    virtual bool supportsAirPlayVideo() const = 0;
> 
> It's kind of weird to have the term "AirPlay" here in a cross-port header.  Could we change this to "supportsRemoteVideoPlayback" or something?

Good point, fixed.

[Eric Carlson]

Created attachment 395070 [details]
Patch for landing

[EWS]

Committed r259303: <https://trac.webkit.org/changeset/259303>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 395070 [details].