Bug 209787 - [Cocoa] UTI from MIME type cache can be removed after r258915
Summary: [Cocoa] UTI from MIME type cache can be removed after r258915
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit Misc. (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Per Arne Vollan
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2020-03-30 15:59 PDT by Per Arne Vollan
Modified: 2020-04-01 17:20 PDT (History)
7 users (show)

See Also:


Attachments
Patch (8.95 KB, patch)
2020-03-30 16:23 PDT, Per Arne Vollan
no flags Details | Formatted Diff | Diff
Patch (18.01 KB, patch)
2020-04-01 06:36 PDT, Per Arne Vollan
no flags Details | Formatted Diff | Diff
Patch (18.06 KB, patch)
2020-04-01 13:04 PDT, Per Arne Vollan
no flags Details | Formatted Diff | Diff
Patch (18.22 KB, patch)
2020-04-01 16:54 PDT, Per Arne Vollan
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Per Arne Vollan 2020-03-30 15:59:49 PDT
In <https://trac.webkit.org/changeset/257828>, a UTI from MIME type cache was added to avoid connecting to a launch services daemon in the WebContent process, but after <https://trac.webkit.org/changeset/258915> this cache is not strictly needed anymore, since <https://trac.webkit.org/changeset/258915> solves the problem of avoiding to connect to the daemon in a general way.
Comment 1 Per Arne Vollan 2020-03-30 16:00:37 PDT
rdar://problem/60714318
Comment 2 Per Arne Vollan 2020-03-30 16:23:00 PDT
Created attachment 394981 [details]
Patch
Comment 3 Tim Horton 2020-03-30 16:28:44 PDT
Comment on attachment 394981 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=394981&action=review

> Source/WebCore/ChangeLog:14
> +        using this cache could possibly be a performance progression if it's done the right way. This investigation
> +        will be done at a later time.

Instead of this, let's just delete the code. It will always live in SVN history if at a later time we want to revive it for the performance progression. We don't tend to keep code in WebKit that is not compiled on any port, because it just rots and causes confusion.
Comment 4 Per Arne Vollan 2020-03-30 16:39:43 PDT
(In reply to Tim Horton from comment #3)
> Comment on attachment 394981 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=394981&action=review
> 
> > Source/WebCore/ChangeLog:14
> > +        using this cache could possibly be a performance progression if it's done the right way. This investigation
> > +        will be done at a later time.
> 
> Instead of this, let's just delete the code. It will always live in SVN
> history if at a later time we want to revive it for the performance
> progression. We don't tend to keep code in WebKit that is not compiled on
> any port, because it just rots and causes confusion.

Sounds good! I will delete the code in the upcoming patch.

Thanks for reviewing!
Comment 5 Per Arne Vollan 2020-04-01 06:36:08 PDT
Created attachment 395160 [details]
Patch
Comment 6 Per Arne Vollan 2020-04-01 13:04:49 PDT
Created attachment 395195 [details]
Patch
Comment 7 EWS 2020-04-01 16:31:06 PDT
Attachment 395195 [details] does not apply
Comment 8 Per Arne Vollan 2020-04-01 16:54:16 PDT
Created attachment 395227 [details]
Patch
Comment 9 EWS 2020-04-01 17:20:00 PDT
Committed r259374: <https://trac.webkit.org/changeset/259374>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 395227 [details].