Bug 209787 – [Cocoa] UTI from MIME type cache can be removed after r258915

• Status: RESOLVED
• Resolution: FIXED
• Component: WebKit Misc.

[Per Arne Vollan]

In <https://trac.webkit.org/changeset/257828>, a UTI from MIME type cache was added to avoid connecting to a launch services daemon in the WebContent process, but after <https://trac.webkit.org/changeset/258915> this cache is not strictly needed anymore, since <https://trac.webkit.org/changeset/258915> solves the problem of avoiding to connect to the daemon in a general way.

[Per Arne Vollan]

rdar://problem/60714318

[Per Arne Vollan]

Created attachment 394981 [details]
Patch

[Tim Horton]

Comment on attachment 394981 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=394981&action=review

> Source/WebCore/ChangeLog:14
> +        using this cache could possibly be a performance progression if it's done the right way. This investigation
> +        will be done at a later time.

Instead of this, let's just delete the code. It will always live in SVN history if at a later time we want to revive it for the performance progression. We don't tend to keep code in WebKit that is not compiled on any port, because it just rots and causes confusion.

[Per Arne Vollan]

(In reply to Tim Horton from comment #3)
> Comment on attachment 394981 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=394981&action=review
> 
> > Source/WebCore/ChangeLog:14
> > +        using this cache could possibly be a performance progression if it's done the right way. This investigation
> > +        will be done at a later time.
> 
> Instead of this, let's just delete the code. It will always live in SVN
> history if at a later time we want to revive it for the performance
> progression. We don't tend to keep code in WebKit that is not compiled on
> any port, because it just rots and causes confusion.

Sounds good! I will delete the code in the upcoming patch.

Thanks for reviewing!

[Per Arne Vollan]

Created attachment 395160 [details]
Patch

[Per Arne Vollan]

Created attachment 395195 [details]
Patch

[EWS]

Attachment 395195 [details] does not apply

[Per Arne Vollan]

Created attachment 395227 [details]
Patch

[EWS]

Committed r259374: <https://trac.webkit.org/changeset/259374>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 395227 [details].