209771 – [Tables] Infinite recursion in RenderTreeBuilder::attach

Bug 209771 - [Tables] Infinite recursion in RenderTreeBuilder::attach

Summary: [Tables] Infinite recursion in RenderTreeBuilder::attach

Status:	RESOLVED FIXED

Alias:	None

Product:	WebKit
Classification:	Unclassified
Component:	Layout and Rendering (show other bugs)
Version:	WebKit Nightly Build
Hardware:	Unspecified Unspecified

Importance:	P2 Normal
Assignee:	zalan

URL:
Keywords:	InRadar

Depends on:
Blocks:

Reported:	2020-03-30 14:36 PDT by zalan
Modified:	2020-04-08 10:38 PDT (History)
CC List:	12 users (show)

See Also:

Attachments
Patch (8.95 KB, patch) 2020-03-30 15:02 PDT, zalan	no flags	Details \| Formatted Diff \| Diff
Patch (9.00 KB, patch) 2020-03-30 16:28 PDT, zalan	no flags	Details \| Formatted Diff \| Diff
Patch (18.46 KB, patch) 2020-03-30 20:14 PDT, zalan	no flags	Details \| Formatted Diff \| Diff
Patch (21.58 KB, patch) 2020-03-31 09:26 PDT, zalan	no flags	Details \| Formatted Diff \| Diff
Show Obsolete (3) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.

Description zalan 2020-03-30 14:36:18 PDT

<rdar://problem/59923112>

Comment 1 zalan 2020-03-30 15:02:34 PDT

Created attachment 394970 [details]
Patch

Comment 2 zalan 2020-03-30 16:28:58 PDT

Created attachment 394983 [details]
Patch

Comment 3 zalan 2020-03-30 20:14:14 PDT

Created attachment 395010 [details]
Patch

Comment 4 zalan 2020-03-31 09:26:47 PDT

Created attachment 395049 [details]
Patch

Comment 5 EWS 2020-03-31 10:04:04 PDT

Committed r259296: <https://trac.webkit.org/changeset/259296>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 395049 [details].

Comment 6 Aakash Jain 2020-04-08 10:38:49 PDT

(In reply to EWS from comment #5)
> Committed r259296: <https://trac.webkit.org/changeset/259296>
This seems to have broke 4 layout-tests on windows as also indicated by ews in https://ews-build.webkit.org/#/builders/10/builds/13486

History: https://results.webkit.org/?suite=layout-tests&suite=layout-tests&suite=layout-tests&suite=layout-tests&test=tables%2Fmozilla_expected_failures%2Fdom%2FappendCol1.html&test=css2.1%2F20110323%2Fmargin-applies-to-006.htm&test=fast%2Ftable%2Ftable-insert-before-non-anonymous-block.html&test=fast%2Fforms%2Fform-hides-table.html&platform=win&platform=wincairo&platform=WPE&platform=linux