Bug 209748 - WebKit should take a foreground assertion for offscreen loads when the app is foreground
Summary: WebKit should take a foreground assertion for offscreen loads when the app is...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit2 (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Chris Dumez
URL:
Keywords: InRadar
Depends on: 209759
Blocks:
  Show dependency tree / graph
 
Reported: 2020-03-30 09:40 PDT by Chris Dumez
Modified: 2020-03-30 16:45 PDT (History)
3 users (show)

See Also:

Attachments
Patch (1.44 KB, patch)
2020-03-30 09:41 PDT, Chris Dumez 		no flags Details | Formatted Diff | Diff
Patch (1.44 KB, patch)
2020-03-30 16:24 PDT, Chris Dumez 		ews-feeder: commit-queue-
Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Chris Dumez 2020-03-30 09:40:39 PDT 
WebKit should take a foreground assertion for offscreen loads when the app is foreground.
Comment 1 Chris Dumez 2020-03-30 09:40:58 PDT 
<rdar://problem/59169812>
Comment 2 Chris Dumez 2020-03-30 09:41:35 PDT 
Created attachment 394927 [details]
Patch
Comment 3 Geoffrey Garen 2020-03-30 10:53:46 PDT 
Comment on attachment 394927 [details]
Patch

r=me
Comment 4 EWS 2020-03-30 11:02:59 PDT 
Committed r259211: <https://trac.webkit.org/changeset/259211>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 394927 [details].
Comment 5 Ryan Haddad 2020-03-30 15:20:09 PDT 
(In reply to EWS from comment #4)
> Committed r259211: <https://trac.webkit.org/changeset/259211>

Seeing hundreds of API tests assert after this change: https://build.webkit.org/builders/Apple%20iOS%2013%20Simulator%20Debug%20WK2%20(Tests)/builds/2865/steps/run-api-tests/logs/stdio
Comment 6 Ryan Haddad 2020-03-30 15:22:52 PDT 
Reverted r259211 for reason:

Caused API test assertion failures on iOS

Committed r259237: <https://trac.webkit.org/changeset/259237>
Comment 7 Chris Dumez 2020-03-30 16:24:29 PDT 
Created attachment 394982 [details]
Patch
Comment 8 EWS 2020-03-30 16:42:59 PDT 
ChangeLog entry in Source/WebKit/ChangeLog contains OOPS!.
Comment 9 Chris Dumez 2020-03-30 16:45:00 PDT 
Committed r259243: <https://trac.webkit.org/changeset/259243>