Bug 209747 - [Cocoa] Minor code cleanup around WebDataListSuggestionsDropdown
Summary: [Cocoa] Minor code cleanup around WebDataListSuggestionsDropdown
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebCore Misc. (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Wenson Hsieh
URL:
Keywords: DoNotImportToRadar
Depends on:
Blocks:
 
Reported: 2020-03-30 09:01 PDT by Wenson Hsieh
Modified: 2020-03-30 10:30 PDT (History)
5 users (show)

See Also:

Attachments
Patch (8.18 KB, patch)
2020-03-30 09:04 PDT, Wenson Hsieh 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Wenson Hsieh 2020-03-30 09:01:11 PDT 
- Make _dropdown a weak pointer instead of a raw pointer.
- Make -showSuggestionsDropdown: take a reference instead of a pointer.
Comment 1 Wenson Hsieh 2020-03-30 09:04:31 PDT 
Created attachment 394923 [details]
Patch
Comment 2 Wenson Hsieh 2020-03-30 10:26:12 PDT 
Comment on attachment 394923 [details]
Patch

Thanks for the review!
Comment 3 EWS 2020-03-30 10:30:06 PDT 
Committed r259207: <https://trac.webkit.org/changeset/259207>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 394923 [details].