Bug 209746 - http://webkit.org/css-status/ hangs
Summary: http://webkit.org/css-status/ hangs
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Simon Fraser (smfr)
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2020-03-30 08:55 PDT by Simon Fraser (smfr)
Modified: 2020-03-30 09:59 PDT (History)
3 users (show)

See Also:


Attachments
Patch (1.79 KB, patch)
2020-03-30 08:56 PDT, Simon Fraser (smfr)
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Simon Fraser (smfr) 2020-03-30 08:55:33 PDT
http://webkit.org/css-status/ hangs
Comment 1 Simon Fraser (smfr) 2020-03-30 08:56:57 PDT
Created attachment 394922 [details]
Patch
Comment 2 Antoine Quint 2020-03-30 09:00:18 PDT
Comment on attachment 394922 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=394922&action=review

> Websites/webkit.org/wp-content/themes/webkit/css-status.php:1604
> +        for (var valueObj of prefixedValues) {

Two potential improvements here:

1. use `const` instead of `var` when declaring `prefixedValues`.
2. do not declare that value and just have `for (var valueObj of Array.from(prefixedPropertyObj.values))`
Comment 3 EWS 2020-03-30 09:58:38 PDT
Committed r259203: <https://trac.webkit.org/changeset/259203>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 394922 [details].
Comment 4 Radar WebKit Bug Importer 2020-03-30 09:59:16 PDT
<rdar://problem/61060038>