WebKit Bugzilla
New
Browse
Search+
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
209731
Delete css-modsel-* tests under css3/ and fast/
https://bugs.webkit.org/show_bug.cgi?id=209731
Summary
Delete css-modsel-* tests under css3/ and fast/
Antti Koivisto
Reported
2020-03-30 04:12:24 PDT
Updated WPT reftest versions of these old tests exist under imported/w3c/web-platform-tests/css/selectors/old-tests. Remove the obsolete (and sometimes flaky) render tree dump versions.
Attachments
patch
(9.95 MB, patch)
2020-03-30 04:19 PDT
,
Antti Koivisto
no flags
Details
Formatted Diff
Diff
patch
(30.97 MB, patch)
2020-03-30 04:26 PDT
,
Antti Koivisto
no flags
Details
Formatted Diff
Diff
patch
(10.29 MB, patch)
2020-03-30 04:51 PDT
,
Antti Koivisto
graouts
: review+
ews-feeder
: commit-queue-
Details
Formatted Diff
Diff
Show Obsolete
(2)
View All
Add attachment
proposed patch, testcase, etc.
Antti Koivisto
Comment 1
2020-03-30 04:19:42 PDT
Created
attachment 394901
[details]
patch
Antti Koivisto
Comment 2
2020-03-30 04:26:45 PDT
Created
attachment 394902
[details]
patch
Antti Koivisto
Comment 3
2020-03-30 04:51:48 PDT
Created
attachment 394905
[details]
patch
EWS
Comment 4
2020-03-30 11:58:38 PDT
commit-queue failed to commit
attachment 394905
[details]
to WebKit repository.
Aakash Jain
Comment 5
2020-03-30 14:36:27 PDT
(In reply to EWS from
comment #4
)
> commit-queue failed to commit
attachment 394905
[details]
to WebKit repository.
This large patch takes ~1.5 hours to apply to repository. Meanwhile there might be other commits to the repository modifying same ChangeLog. Therefore commit-queue might keep failing to land this. Better to cq+ in off-peak hours, or land it manually.
EWS
Comment 6
2020-03-30 16:06:14 PDT
commit-queue failed to commit
attachment 394905
[details]
to WebKit repository.
Antti Koivisto
Comment 7
2020-03-30 23:00:49 PDT
Committed revision 259281.
Antti Koivisto
Comment 8
2020-03-30 23:02:11 PDT
https://trac.webkit.org/changeset/259281/webkit
Radar WebKit Bug Importer
Comment 9
2020-03-30 23:03:25 PDT
<
rdar://problem/61091731
>
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug