Bug 209717 - [LFC] Replace parent() calls with containingBlock() where applicable.
Summary: [LFC] Replace parent() calls with containingBlock() where applicable.
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Layout and Rendering (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: zalan
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2020-03-29 08:44 PDT by zalan
Modified: 2020-03-29 10:31 PDT (History)
5 users (show)

See Also:


Attachments
Patch (7.04 KB, patch)
2020-03-29 08:55 PDT, zalan
no flags Details | Formatted Diff | Diff
Patch (6.44 KB, patch)
2020-03-29 09:47 PDT, zalan
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description zalan 2020-03-29 08:44:02 PDT
while they return the same layout box (parent), it's more correct to call containingBlock on them.
Comment 1 zalan 2020-03-29 08:55:35 PDT
Created attachment 394866 [details]
Patch
Comment 2 zalan 2020-03-29 09:47:35 PDT
Created attachment 394868 [details]
Patch
Comment 3 EWS 2020-03-29 10:30:04 PDT
Committed r259181: <https://trac.webkit.org/changeset/259181>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 394868 [details].
Comment 4 Radar WebKit Bug Importer 2020-03-29 10:31:12 PDT
<rdar://problem/61029530>