WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
209714
ScrollLatchingState should use WeakPtr<Element>
https://bugs.webkit.org/show_bug.cgi?id=209714
Summary
ScrollLatchingState should use WeakPtr<Element>
Simon Fraser (smfr)
Reported
2020-03-28 20:20:47 PDT
ScrollLatchingState should use WeakPtr<Element>
Attachments
Patch
(6.96 KB, patch)
2020-03-28 20:21 PDT
,
Simon Fraser (smfr)
darin
: review+
Details
Formatted Diff
Diff
View All
Add attachment
proposed patch, testcase, etc.
Simon Fraser (smfr)
Comment 1
2020-03-28 20:21:33 PDT
Created
attachment 394856
[details]
Patch
Darin Adler
Comment 2
2020-03-29 01:13:02 PDT
Comment on
attachment 394856
[details]
Patch View in context:
https://bugs.webkit.org/attachment.cgi?id=394856&action=review
> Source/WebCore/page/scrolling/ScrollLatchingState.h:48 > + void setWheelEventElement(Element*);
Does this need to accept null? Could it take a references instead of a pointer?
> Source/WebCore/page/scrolling/ScrollLatchingState.h:57 > + void setPreviousWheelScrolledElement(Element*);
Ditto.
> Source/WebCore/page/scrolling/ScrollLatchingState.h:61 > +
Ditto.
Simon Fraser (smfr)
Comment 3
2020-03-30 20:35:57 PDT
https://trac.webkit.org/changeset/259278/webkit
Radar WebKit Bug Importer
Comment 4
2020-03-30 20:36:15 PDT
<
rdar://problem/61087846
>
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug