[selectors-4] Rename :matches() to :is() <https://github.com/w3c/csswg-drafts/issues/3258>
Created attachment 394841 [details] Patch
Comment on attachment 394841 [details] Patch Nice!
Comment on attachment 394841 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=394841&action=review > Source/WebCore/css/CSSSelector.h:125 > + PseudoClassIs, > PseudoClassMatches, Might want to add a comment on PseudoClassMatches here, mentioning it is an obsolete synonym for PseudoClassIs.
Created attachment 394931 [details] Patch
Comment on attachment 394931 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=394931&action=review > Source/WebCore/ChangeLog:38 > + imported/w3c/web-platform-tests/css/selectors/invalidation/is.html > + imported/w3c/web-platform-tests/css/selectors/is-nested.html > + imported/w3c/web-platform-tests/css/selectors/is-specificity.html You should not change these tests directly. Changes need to get upstream to WPT from http/wpt/
Meanwhile you can just land modified versions outside imported/w3c/web-platform-tests and skips the WPT versions.
...or land them as failures.
Comment on attachment 394931 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=394931&action=review >> Source/WebCore/ChangeLog:38 >> + imported/w3c/web-platform-tests/css/selectors/is-specificity.html > > You should not change these tests directly. Changes need to get upstream to WPT from http/wpt/ They've already been changed in upstream <https://github.com/web-platform-tests/wpt/pull/14071>.
(In reply to Devin Rousso from comment #8) > Comment on attachment 394931 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=394931&action=review > > >> Source/WebCore/ChangeLog:38 > >> + imported/w3c/web-platform-tests/css/selectors/is-specificity.html > > > > You should not change these tests directly. Changes need to get upstream to WPT from http/wpt/ > > They've already been changed in upstream > <https://github.com/web-platform-tests/wpt/pull/14071>. Then wait for that to land, re-import (marking failing), then land this patch?
(In reply to Simon Fraser (smfr) from comment #9) > (In reply to Devin Rousso from comment #8) > > Comment on attachment 394931 [details] > > Patch > > > > View in context: > > https://bugs.webkit.org/attachment.cgi?id=394931&action=review > > > > >> Source/WebCore/ChangeLog:38 > > >> + imported/w3c/web-platform-tests/css/selectors/is-specificity.html > > > > > > You should not change these tests directly. Changes need to get upstream to WPT from http/wpt/ > > > > They've already been changed in upstream <https://github.com/web-platform-tests/wpt/pull/14071>. > > Then wait for that to land, re-import (marking failing), then land this patch? They've already landed too 😅 <https://github.com/web-platform-tests/wpt/commit/4decb8a>
Created attachment 394949 [details] Patch Looks like Antti already imported the WPT for `:is()` in r259194 :)
Created attachment 394954 [details] Patch
Committed r259261: <https://trac.webkit.org/changeset/259261> All reviewed patches have been landed. Closing bug and clearing flags on attachment 394954 [details].
<rdar://problem/61082755>