Bug 209663 – Add missing scope release to DataView's buffer getter

• Status: RESOLVED
• Resolution: FIXED
• Component: New Bugs

[Keith Miller]

Add missing scope release to DataView's buffer getter

[Keith Miller]

Created attachment 394729 [details]
Patch

[Darin Adler]

Comment on attachment 394729 [details]
Patch

I want to know how to write correct patches in the futures. How do we notice in tests if we get something like this wrong?

[EWS]

Committed r259127: <https://trac.webkit.org/changeset/259127>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 394729 [details].

[Radar WebKit Bug Importer]

<rdar://problem/60975866>

[Keith Miller]

(In reply to Darin Adler from comment #2)
> Comment on attachment 394729 [details]
> Patch
> 
> I want to know how to write correct patches in the futures. How do we notice
> in tests if we get something like this wrong?

You'll see these if you set the JSC_validateExceptionChecks environment variable to 1 or "true". WKTR might need __XPC_JSC_validateExceptionChecks, though. 

That said, I think only JSC runs tests with this option since WebCore has so many false positives i.e not releasing the scope before tail-calling like here. At some point we should sit down and fix those...

[Keith Miller]

(In reply to Keith Miller from comment #5)
> (In reply to Darin Adler from comment #2)
> > Comment on attachment 394729 [details]
> > Patch
> > 
> > I want to know how to write correct patches in the futures. How do we notice
> > in tests if we get something like this wrong?
> 
> You'll see these if you set the JSC_validateExceptionChecks environment
> variable to 1 or "true". WKTR might need __XPC_JSC_validateExceptionChecks,
> though. 

You'll also need a Debug or Release-Assert build.

[Keith Miller]

*** Bug 209658 has been marked as a duplicate of this bug. ***