Bug 209663 - Add missing scope release to DataView's buffer getter
Summary: Add missing scope release to DataView's buffer getter
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Keith Miller
URL:
Keywords: InRadar
: 209658 (view as bug list)
Depends on:
Blocks:
 
Reported: 2020-03-27 10:42 PDT by Keith Miller
Modified: 2020-03-27 11:39 PDT (History)
9 users (show)

See Also:

Attachments
Patch (1.56 KB, patch)
2020-03-27 10:42 PDT, Keith Miller 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Keith Miller 2020-03-27 10:42:13 PDT 
Add missing scope release to DataView's buffer getter
Comment 1 Keith Miller 2020-03-27 10:42:27 PDT 
Created attachment 394729 [details]
Patch
Comment 2 Darin Adler 2020-03-27 10:56:14 PDT 
Comment on attachment 394729 [details]
Patch

I want to know how to write correct patches in the futures. How do we notice in tests if we get something like this wrong?
Comment 3 EWS 2020-03-27 11:06:05 PDT 
Committed r259127: <https://trac.webkit.org/changeset/259127>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 394729 [details].
Comment 4 Radar WebKit Bug Importer 2020-03-27 11:07:16 PDT 
<rdar://problem/60975866>
Comment 5 Keith Miller 2020-03-27 11:08:38 PDT 
(In reply to Darin Adler from comment #2)
> Comment on attachment 394729 [details]
> Patch
> 
> I want to know how to write correct patches in the futures. How do we notice
> in tests if we get something like this wrong?

You'll see these if you set the JSC_validateExceptionChecks environment variable to 1 or "true". WKTR might need __XPC_JSC_validateExceptionChecks, though. 

That said, I think only JSC runs tests with this option since WebCore has so many false positives i.e not releasing the scope before tail-calling like here. At some point we should sit down and fix those...
Comment 6 Keith Miller 2020-03-27 11:09:27 PDT 
(In reply to Keith Miller from comment #5)
> (In reply to Darin Adler from comment #2)
> > Comment on attachment 394729 [details]
> > Patch
> > 
> > I want to know how to write correct patches in the futures. How do we notice
> > in tests if we get something like this wrong?
> 
> You'll see these if you set the JSC_validateExceptionChecks environment
> variable to 1 or "true". WKTR might need __XPC_JSC_validateExceptionChecks,
> though. 

You'll also need a Debug or Release-Assert build.
Comment 7 Keith Miller 2020-03-27 11:39:01 PDT 
*** Bug 209658 has been marked as a duplicate of this bug. ***