WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
20965
Refactor HTMLImageLoader, share code with SVGImageLoader
https://bugs.webkit.org/show_bug.cgi?id=20965
Summary
Refactor HTMLImageLoader, share code with SVGImageLoader
Nikolas Zimmermann
Reported
2008-09-20 11:42:37 PDT
HTMLImageLoader should be copied to loader/ImageLoader, and should serve as base class for both HTMLImageLoader & SVGImageLoader.
Attachments
Initial patch
(37.71 KB, patch)
2008-09-20 12:54 PDT
,
Nikolas Zimmermann
eric
: review+
Details
Formatted Diff
Diff
View All
Add attachment
proposed patch, testcase, etc.
Nikolas Zimmermann
Comment 1
2008-09-20 12:54:48 PDT
Created
attachment 23610
[details]
Initial patch
Eric Seidel (no email)
Comment 2
2008-09-20 13:14:29 PDT
Comment on
attachment 23610
[details]
Initial patch I assume you ran the layout tests. Looks sane enough. Difficult to do a very detailed review on this code move.
Nikolas Zimmermann
Comment 3
2008-09-20 13:20:13 PDT
Landed in
r36712
.
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug