Bug 20965 - Refactor HTMLImageLoader, share code with SVGImageLoader
Summary: Refactor HTMLImageLoader, share code with SVGImageLoader
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: SVG (show other bugs)
Version: 528+ (Nightly build)
Hardware: Mac OS X 10.5
: P2 Normal
Assignee: Nikolas Zimmermann
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2008-09-20 11:42 PDT by Nikolas Zimmermann
Modified: 2008-09-20 13:20 PDT (History)
0 users

See Also:


Attachments
Initial patch (37.71 KB, patch)
2008-09-20 12:54 PDT, Nikolas Zimmermann
eric: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Nikolas Zimmermann 2008-09-20 11:42:37 PDT
HTMLImageLoader should be copied to loader/ImageLoader, and should serve as base class for both HTMLImageLoader & SVGImageLoader.
Comment 1 Nikolas Zimmermann 2008-09-20 12:54:48 PDT
Created attachment 23610 [details]
Initial patch
Comment 2 Eric Seidel (no email) 2008-09-20 13:14:29 PDT
Comment on attachment 23610 [details]
Initial patch

I assume you ran the layout tests.  Looks sane enough.  Difficult to do a very detailed review on this code move.
Comment 3 Nikolas Zimmermann 2008-09-20 13:20:13 PDT
Landed in r36712.