Bug 209648 - [Flatpak SDK] build-webkit --flatpak-cmakeargs option is ignored
Summary: [Flatpak SDK] build-webkit --flatpak-cmakeargs option is ignored
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Philippe Normand
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2020-03-27 03:34 PDT by Philippe Normand
Modified: 2020-04-03 02:22 PDT (History)
6 users (show)

See Also:


Attachments
Patch (14.32 KB, patch)
2020-04-01 08:43 PDT, Philippe Normand
zan: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Philippe Normand 2020-03-27 03:34:22 PDT
Because build-webkit spawns webkit-flatpak --command="build-webkit  ..." instead of webkit-flatpak -b. I'm not sure this -b makes much sense anymore.
Comment 1 Philippe Normand 2020-03-27 03:40:02 PDT
Generally speaking, I think webkit-flatpak has too many, redundant, options... Maybe we can remove most of those?

For instance, --tests doesn't seem necessary as we should use run-webkit-tests directly. Dunno. Just some thoughts :)
Comment 2 Philippe Normand 2020-04-01 08:43:25 PDT
Created attachment 395170 [details]
Patch
Comment 3 Carlos Alberto Lopez Perez 2020-04-01 09:44:24 PDT
Speaking for myself I use none of those..

I run the scripts (run-minibrowser, run-webkit-tests, etc) directly and I expect those scripts to work automatically with flatpak if I have previously built the third-party libraries with flatpak.

But I don't know if somebody else uses this :?
Comment 4 Philippe Normand 2020-04-01 09:54:22 PDT
To my knowledge Thibault was the only one using webkit-flatpak directly. I use it occasionally but only to get in the sandbox or run gdb. I also use the existing scripts whenever possible.
Comment 5 Adrian Perez 2020-04-01 14:30:06 PDT
(In reply to Philippe Normand from comment #4)
> To my knowledge Thibault was the only one using webkit-flatpak directly. I
> use it occasionally but only to get in the sandbox or run gdb. I also use
> the existing scripts whenever possible.

I have used “webkit-flatpak” directly sometimes, most of the time it's
nicer to use the existing scripts, but having the escape hatch to do
things “by hand” with the Flatpak environment is handy — the same way
as having the “jhbuild-wrapper” script has been useful sometimes.
Comment 6 Philippe Normand 2020-04-02 01:45:50 PDT
Which webkit-flatpak options do you use? This patch doesn't remove all of them :)
Comment 7 Philippe Normand 2020-04-03 02:21:34 PDT
Committed r259451: <https://trac.webkit.org/changeset/259451>
Comment 8 Radar WebKit Bug Importer 2020-04-03 02:22:13 PDT
<rdar://problem/61251129>