Bug 209648 – [Flatpak SDK] build-webkit --flatpak-cmakeargs option is ignored

• Status: RESOLVED
• Resolution: FIXED
• Component: Tools / Tests

[Philippe Normand]

Because build-webkit spawns webkit-flatpak --command="build-webkit  ..." instead of webkit-flatpak -b. I'm not sure this -b makes much sense anymore.

[Philippe Normand]

Generally speaking, I think webkit-flatpak has too many, redundant, options... Maybe we can remove most of those?

For instance, --tests doesn't seem necessary as we should use run-webkit-tests directly. Dunno. Just some thoughts :)

[Philippe Normand]

Created attachment 395170 [details]
Patch

[Carlos Alberto Lopez Perez]

Speaking for myself I use none of those..

I run the scripts (run-minibrowser, run-webkit-tests, etc) directly and I expect those scripts to work automatically with flatpak if I have previously built the third-party libraries with flatpak.

But I don't know if somebody else uses this :?

[Philippe Normand]

To my knowledge Thibault was the only one using webkit-flatpak directly. I use it occasionally but only to get in the sandbox or run gdb. I also use the existing scripts whenever possible.

[Adrian Perez]

(In reply to Philippe Normand from comment #4)
> To my knowledge Thibault was the only one using webkit-flatpak directly. I
> use it occasionally but only to get in the sandbox or run gdb. I also use
> the existing scripts whenever possible.

I have used “webkit-flatpak” directly sometimes, most of the time it's
nicer to use the existing scripts, but having the escape hatch to do
things “by hand” with the Flatpak environment is handy — the same way
as having the “jhbuild-wrapper” script has been useful sometimes.

[Philippe Normand]

Which webkit-flatpak options do you use? This patch doesn't remove all of them :)

[Philippe Normand]

Committed r259451: <https://trac.webkit.org/changeset/259451>

[Radar WebKit Bug Importer]

<rdar://problem/61251129>