Bug 209647 - [WPE] Unnecessary gl synchronization when using an OpenMAX video decoder and GLES2
Summary: [WPE] Unnecessary gl synchronization when using an OpenMAX video decoder and ...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WPE WebKit (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Miguel Gomez
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2020-03-27 03:16 PDT by Miguel Gomez
Modified: 2020-03-27 06:14 PDT (History)
14 users (show)

See Also:


Attachments
Patch (3.15 KB, patch)
2020-03-27 03:39 PDT, Miguel Gomez
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Miguel Gomez 2020-03-27 03:16:41 PDT
On platforms that use an OpenMAX video decoder (like the rpi3) and GLES2, the call to gst_gl_sync_meta_wait_cpu() (which is internally translated into a glFinish call), causes unnecessary waits when trying to the video frame using gstreamer-gl, reducing the framerate. On these platforms the call to gst_gl_sync_meta_wait_cpu() can be omitted cause we know that OpenGL will ensure that the video frame will be ready when we want to draw it.
Comment 1 Miguel Gomez 2020-03-27 03:39:02 PDT
Created attachment 394715 [details]
Patch
Comment 2 Adrian Perez 2020-03-27 05:45:12 PDT
Minor nit: The bug tile should have “[GStreamer]” instead of “[WPE]” 😉️
Comment 3 Xabier Rodríguez Calvar 2020-03-27 06:04:46 PDT
Comment on attachment 394715 [details]
Patch

I would have changed the name of the method to waitForCPUSyncIfNeeded
Comment 4 EWS 2020-03-27 06:14:06 PDT
Committed r259113: <https://trac.webkit.org/changeset/259113>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 394715 [details].