Bug 209645 – [WebAuthn] Relaxing signature length requirements for U2fRegister

• Status: VERIFIED
• Resolution: FIXED
• Component: WebKit Misc.

[nuno.sung]

Created attachment 394713 [details]
Progress stops like this.

[Environment]
Test Device: MacBook Pro (2013)
OS: macOS 10.15.4
Safari 13.1 (15609.1.20.111.8)
Safari Technology Preview Release 103

[Repro Steps]
1.Click 2-step verification item.
2.Click "Add security key" item.
3.Select USB item.
4.Click next button.
5.Insert one Security Key, wait it to start blinking and touch it.
6.Sometimes the registration progress stops and the Security Key stop blinking.

[Result]
Below are the reproducible rate on different Security Keys
- Yubico Security Key : 1/8
- Google U2F key: 1/5
- Yubikey 4 : 1/5

[nuno.sung]

Just see a similar issue "70-byte attestation signature will be rejected" described in
https://medium.com/@darconeous/thoughts-on-apples-fido2-support-44a2aadcf093

[Jiewen Tan]

This behavior seems to be only reproducible with Google. I tried Google, and it reproduced. I tried https://webauthntest.azurewebsites.net but failed. Wondering if this is actually an issue with quirks we did for Google.

[Radar WebKit Bug Importer]

<rdar://problem/63204591>

[Jiewen Tan]

Created attachment 399322 [details]
Patch

[Brent Fulgham]

Comment on attachment 399322 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=399322&action=review

r=me

> Source/WebCore/ChangeLog:12
> +        It should actually be [70, 72]. However, as a middleware to relay the messages, user agents

Should we add a console message about this so web developers could see the message was out-of-bounds?

[Jiewen Tan]

Comment on attachment 399322 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=399322&action=review

Thanks Brent for the r+.

>> Source/WebCore/ChangeLog:12
>> +        It should actually be [70, 72]. However, as a middleware to relay the messages, user agents
> 
> Should we add a console message about this so web developers could see the message was out-of-bounds?

Probably yes. Not sure why developers would care the range though.

[EWS]

Committed r261723: <https://trac.webkit.org/changeset/261723>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 399322 [details].

[Jiewen Tan]

(In reply to nuno.sung from comment #0)
> Created attachment 394713 [details]
> Progress stops like this.
> 
> [Environment]
> Test Device: MacBook Pro (2013)
> OS: macOS 10.15.4
> Safari 13.1 (15609.1.20.111.8)
> Safari Technology Preview Release 103
> 
> [Repro Steps]
> 1.Click 2-step verification item.
> 2.Click "Add security key" item.
> 3.Select USB item.
> 4.Click next button.
> 5.Insert one Security Key, wait it to start blinking and touch it.
> 6.Sometimes the registration progress stops and the Security Key stop
> blinking.
> 
> [Result]
> Below are the reproducible rate on different Security Keys
> - Yubico Security Key : 1/8
> - Google U2F key: 1/5
> - Yubikey 4 : 1/5

Hi, please follow our STP updates to verify the fix.

[nuno.sung]

Sorry for my late reply.
I can verify this issue on the same MacBook Pro
macOS 10.15.5
Safari Technology Preview Release 108

- Yubico Security Key NFC (test with USB): 0/20
- Google U2F key: 0/20
- ATKey.Pro : 0/20

[Jiewen Tan]

(In reply to nuno.sung from comment #9)
> Sorry for my late reply.
> I can verify this issue on the same MacBook Pro
> macOS 10.15.5
> Safari Technology Preview Release 108
> 
> - Yubico Security Key NFC (test with USB): 0/20
> - Google U2F key: 0/20
> - ATKey.Pro : 0/20

Thanks, Nuno.