Bug 209628 - Regression: Unable to trigger context menu on empty tabs in Safari
Summary: Regression: Unable to trigger context menu on empty tabs in Safari
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit2 (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Chris Dumez
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2020-03-26 16:35 PDT by Chris Dumez
Modified: 2020-03-26 18:37 PDT (History)
3 users (show)

See Also:

Attachments
Patch (1.44 KB, patch)
2020-03-26 16:37 PDT, Chris Dumez 		no flags Details | Formatted Diff | Diff
Patch (1.49 KB, patch)
2020-03-26 17:54 PDT, Chris Dumez 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Chris Dumez 2020-03-26 16:35:38 PDT 
Unable to trigger context menu on empty tabs in Safari.
Comment 1 Chris Dumez 2020-03-26 16:37:39 PDT 
Created attachment 394674 [details]
Patch
Comment 2 Geoffrey Garen 2020-03-26 16:40:25 PDT 
Comment on attachment 394674 [details]
Patch

r=me

Should we do something specific to skip mouseover and mousemove events? Would be a shame to launch a process just because a view was under the mouse.
Comment 3 Chris Dumez 2020-03-26 16:45:38 PDT 
(In reply to Geoffrey Garen from comment #2)
> Comment on attachment 394674 [details]
> Patch
> 
> r=me
> 
> Should we do something specific to skip mouseover and mousemove events?
> Would be a shame to launch a process just because a view was under the mouse.

That is a good idea. I will see how easy that is.
Comment 4 Chris Dumez 2020-03-26 17:54:30 PDT 
Created attachment 394684 [details]
Patch
Comment 5 EWS 2020-03-26 18:36:04 PDT 
Committed r259097: <https://trac.webkit.org/changeset/259097>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 394684 [details].
Comment 6 Radar WebKit Bug Importer 2020-03-26 18:37:15 PDT 
<rdar://problem/60946732>