Bug 209623 - Rename -_isInteractingWithFocusedElement, add it to the header, and replace calls to hasFocusedElement() with it
Summary: Rename -_isInteractingWithFocusedElement, add it to the header, and replace c...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit Misc. (show other bugs)
Version: WebKit Local Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Daniel Bates
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2020-03-26 15:20 PDT by Daniel Bates
Modified: 2020-03-26 16:10 PDT (History)
2 users (show)

See Also:

Attachments
Patch (16.35 KB, patch)
2020-03-26 15:33 PDT, Daniel Bates 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Daniel Bates 2020-03-26 15:20:29 PDT 
The code in WKContentViewInteraction.mm uses either [self _isInteractingWithFocusedElement] or hasFocusedElement(_focusedElementInformation) to check if there is a currently focused keyboard-assisted element. The former is just a convenience function for the latter. There is never more than one focused element so hasFocusedElement() is always passed _focusedElementInformation. So, let's remove hasFocusedElement() and standardize on -_isInteractingWithFocusedElement. We might as well consider renaming -_isInteractingWithFocusedElement at the same time.
Comment 1 Daniel Bates 2020-03-26 15:33:39 PDT 
Created attachment 394663 [details]
Patch
Comment 2 Radar WebKit Bug Importer 2020-03-26 15:58:54 PDT 
<rdar://problem/60940521>
Comment 3 Daniel Bates 2020-03-26 16:10:40 PDT 
Comment on attachment 394663 [details]
Patch

Clearing flags on attachment: 394663

Committed r259091: <https://trac.webkit.org/changeset/259091>
Comment 4 Daniel Bates 2020-03-26 16:10:41 PDT 
All reviewed patches have been landed.  Closing bug.