Bug 209621 – [ Mac wk1 ] fast/loader/child-frame-add-after-back-forward.html is flaky timing out.

• Status: RESOLVED
• Resolution: FIXED
• Component: Frames

[Jason Lawrence]

fast/loader/child-frame-add-after-back-forward.html 

Description:
This test is flaky timing out on Mac wk1. The flaky timeouts are apparent through most of the visible history, with the oldest appearing on 12/31/2019.

History:
https://results.webkit.org/?suite=layout-tests&test=fast%2Floader%2Fchild-frame-add-after-back-forward.html&platform=mac&flavor=wk1&style=release&style=debug&limit=50000

Diff:
--- /Volumes/Data/slave/catalina-debug-tests-wk1/build/layout-test-results/fast/loader/child-frame-add-after-back-forward-expected.txt
+++ /Volumes/Data/slave/catalina-debug-tests-wk1/build/layout-test-results/fast/loader/child-frame-add-after-back-forward-actual.txt
@@ -1,8 +1,5 @@
 main frame - has 1 onunload handler(s)
-main frame - has 1 onunload handler(s)
-Go forward then back.  
+FAIL: Timed out waiting for notifyDone to be called
+This tests the parsing of charset in the meta tag. The following should be a Hebrew word:
 
---------
-Frame: '<!--frame1-->'
---------
-PASS
+עברית

[Radar WebKit Bug Importer]

<rdar://problem/60937276>

[Jason Lawrence]

I have marked this test as timing out while this issue is investigated.
https://trac.webkit.org/changeset/259082/webkit

[Chris Dumez]

Looks like this could be a test harness issue, not an issue with the test in question. The output seems to be for another test:
fast/loader/charset-parse.html

Likely the preceding test.

[Chris Dumez]

(In reply to Chris Dumez from comment #3)
> Looks like this could be a test harness issue, not an issue with the test in
> question. The output seems to be for another test:
> fast/loader/charset-parse.html
> 
> Likely the preceding test.

Or maybe  fast/loader/child-frame-add-after-back-forward.html ends up navigating too far back in some cases (back to the previous test which was loaded in the same view). I think this makes some sense.

[Chris Dumez]

Unable to reproduce so far. If someone is, please let me know how.

[Chris Dumez]

I don't see anything particularly wrong or racy with the test..

[Chris Dumez]

Created attachment 395275 [details]
Patch

[EWS]

Committed r259395: <https://trac.webkit.org/changeset/259395>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 395275 [details].