Bug 209606 - IndexedDB: destroy WebIDBServer when session is removed in network process
Summary: IndexedDB: destroy WebIDBServer when session is removed in network process
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Sihui Liu
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2020-03-26 10:29 PDT by Sihui Liu
Modified: 2020-03-31 15:19 PDT (History)
10 users (show)

See Also:

Attachments
Patch (11.20 KB, patch)
2020-03-26 10:40 PDT, Sihui Liu 		no flags Details | Formatted Diff | Diff
Patch for landing (12.39 KB, patch)
2020-03-31 14:54 PDT, Sihui Liu 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Sihui Liu 2020-03-26 10:29:05 PDT 
Also perform necessary cleanup on WebIDBServer before deleting it.
Comment 1 Sihui Liu 2020-03-26 10:29:38 PDT 
<rdar://problem/59310081>
Comment 2 Sihui Liu 2020-03-26 10:40:16 PDT 
Created attachment 394624 [details]
Patch
Comment 3 Geoffrey Garen 2020-03-27 09:09:36 PDT 
Comment on attachment 394624 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=394624&action=review

r=me

> Source/WebKit/NetworkProcess/IndexedDB/WebIDBServer.cpp:375
> +void WebIDBServer::destroy()

Since this doesn't directly delete the object, I think a name like "close" or "invalidate" would be better.
Comment 4 Sihui Liu 2020-03-31 14:54:20 PDT 
Created attachment 395094 [details]
Patch for landing
Comment 5 EWS 2020-03-31 15:19:32 PDT 
Committed r259316: <https://trac.webkit.org/changeset/259316>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 395094 [details].