WebKit Bugzilla
New
Browse
Search+
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
209602
REGRESSION(
r259042
): It creates some test failures (Requested by youenn on #webkit).
https://bugs.webkit.org/show_bug.cgi?id=209602
Summary
REGRESSION(r259042): It creates some test failures (Requested by youenn on #w...
WebKit Commit Bot
Reported
2020-03-26 09:09:02 PDT
https://trac.webkit.org/changeset/259042
broke the build: It creates some test failures (Requested by youenn on #webkit). This is an automatic bug report generated by webkitbot. If this bug report was created because of a flaky test, please file a bug for the flaky test (if we don't already have one on file) and dup this bug against that bug so that we can track how often these flaky tests fail.
Attachments
REVERT of r259042
(25.78 MB, patch)
2020-03-26 09:10 PDT
,
WebKit Commit Bot
ews-feeder
: commit-queue-
Details
Formatted Diff
Diff
View All
Add attachment
proposed patch, testcase, etc.
WebKit Commit Bot
Comment 1
2020-03-26 09:10:16 PDT
Created
attachment 394618
[details]
REVERT of
r259042
Any committer can land this patch automatically by marking it commit-queue+. The commit-queue will build and test the patch before landing to ensure that the revert will be successful. This process takes approximately 15 minutes. If you would like to land the revert faster, you can use the following command: webkit-patch land-attachment ATTACHMENT_ID where ATTACHMENT_ID is the ID of this attachment.
EWS
Comment 2
2020-03-26 09:17:27 PDT
commit-queue failed to commit
attachment 394618
[details]
to WebKit repository.
Ryan Haddad
Comment 3
2020-03-26 10:26:16 PDT
(In reply to EWS from
comment #2
)
> commit-queue failed to commit
attachment 394618
[details]
to WebKit > repository.
ERROR from SVN: A repository hook failed: Commit blocked by pre-commit hook (exit code 1) with output: The following files contain tab characters: trunk/Source/ThirdParty/libwebrtc/Source/third_party/boringssl/src/crypto/fipsmodule/aes/asm/aes-586.pl trunk/Source/ThirdParty/libwebrtc/Source/third_party/boringssl/src/crypto/fipsmodule/aes/asm/aes-armv4.pl trunk/Source/ThirdParty/libwebrtc/Source/third_party/boringssl/src/crypto/fipsmodule/aes/asm/aes-x86_64.pl Please use spaces instead to indent. If you must commit a file with tabs, use svn propset to set the "allow-tabs" property.
Alexey Proskuryakov
Comment 4
2020-03-26 10:51:52 PDT
Landed the rollback in
http://trac.webkit.org/r259054
Radar WebKit Bug Importer
Comment 5
2020-03-26 10:52:16 PDT
<
rdar://problem/60926366
>
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug