Bug 209593 - [GTK][WPE] REGRESSION(r257775): Media controls current time label changes its size when it's updated
Summary: [GTK][WPE] REGRESSION(r257775): Media controls current time label changes its...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKitGTK (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords: Gtk, Regression
Depends on: 209591
Blocks:
  Show dependency treegraph
 
Reported: 2020-03-26 05:46 PDT by Carlos Garcia Campos
Modified: 2020-03-30 02:35 PDT (History)
9 users (show)

See Also:


Attachments
Patch (1.99 KB, patch)
2020-03-26 05:50 PDT, Carlos Garcia Campos
calvaris: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Carlos Garcia Campos 2020-03-26 05:46:26 PDT
This regressed in r257775 for me, because my system font doesn't use fixed width for digits. We should try to use the tabular-nums font variant if available.
Comment 1 Carlos Garcia Campos 2020-03-26 05:50:07 PDT
Created attachment 394597 [details]
Patch
Comment 2 Xabier Rodríguez Calvar 2020-03-26 06:06:36 PDT
Comment on attachment 394597 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=394597&action=review

> Source/WebCore/Modules/mediacontrols/mediaControlsAdwaita.css:-224
> -audio::-webkit-media-controls-time-remaining-display.hidden,
> -video::-webkit-media-controls-time-remaining-display.hidden {

Why do you remove this?
Comment 3 Carlos Garcia Campos 2020-03-26 06:12:52 PDT
(In reply to Xabier Rodríguez Calvar from comment #2)
> Comment on attachment 394597 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=394597&action=review
> 
> > Source/WebCore/Modules/mediacontrols/mediaControlsAdwaita.css:-224
> > -audio::-webkit-media-controls-time-remaining-display.hidden,
> > -video::-webkit-media-controls-time-remaining-display.hidden {
> 
> Why do you remove this?

Because there isn't any time remaining label. It's a bit unrelated to this patch, I realized working on this, but I can move it to its own patch.
Comment 4 Adrian Perez 2020-03-26 07:02:00 PDT
Comment on attachment 394597 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=394597&action=review

> Source/WebCore/Modules/mediacontrols/mediaControlsAdwaita.css:203
> +    font-variant-numeric: tabular-nums;

OpenType Font Features 💖️
Comment 5 Xabier Rodríguez Calvar 2020-03-26 08:24:15 PDT
Comment on attachment 394597 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=394597&action=review

>>> Source/WebCore/Modules/mediacontrols/mediaControlsAdwaita.css:-224
>>> -video::-webkit-media-controls-time-remaining-display.hidden {
>> 
>> Why do you remove this?
> 
> Because there isn't any time remaining label. It's a bit unrelated to this patch, I realized working on this, but I can move it to its own patch.

I would prefer you move it to its own patch but I don't care too much, your call.
Comment 6 Carlos Garcia Campos 2020-03-30 02:35:12 PDT
Committed r259191: <https://trac.webkit.org/changeset/259191>