Bug 209568 - [macOS] Fix sandbox violations related to media playback
Summary: [macOS] Fix sandbox violations related to media playback
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit Misc. (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Per Arne Vollan
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2020-03-25 15:55 PDT by Per Arne Vollan
Modified: 2020-03-25 16:52 PDT (History)
3 users (show)

See Also:

Attachments
Patch (1.50 KB, patch)
2020-03-25 15:57 PDT, Per Arne Vollan 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Per Arne Vollan 2020-03-25 15:55:26 PDT 
Fix observed sandbox violations during media playback.
Comment 1 Per Arne Vollan 2020-03-25 15:55:57 PDT 
rdar://problem/60262125
Comment 2 Per Arne Vollan 2020-03-25 15:57:46 PDT 
Created attachment 394557 [details]
Patch
Comment 3 Brent Fulgham 2020-03-25 16:02:28 PDT 
Comment on attachment 394557 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=394557&action=review

r=me

> Source/WebKit/UIProcess/Cocoa/WebProcessPoolCocoa.mm:256
> +#if PLATFORM(MAC) || PLATFORM(MACCATALYST)

This is my fault! Thank you for fixing this.
Comment 4 Per Arne Vollan 2020-03-25 16:20:19 PDT 
(In reply to Brent Fulgham from comment #3)
> Comment on attachment 394557 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=394557&action=review
> 
> r=me
> 
> > Source/WebKit/UIProcess/Cocoa/WebProcessPoolCocoa.mm:256
> > +#if PLATFORM(MAC) || PLATFORM(MACCATALYST)
> 
> This is my fault! Thank you for fixing this.

Thanks for reviewing!
Comment 5 EWS 2020-03-25 16:52:31 PDT 
Committed r259023: <https://trac.webkit.org/changeset/259023>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 394557 [details].