Bug 209558 - [Flatpak SDK] Pass all the arguments of build-webkit to webkit-flatpak
Summary: [Flatpak SDK] Pass all the arguments of build-webkit to webkit-flatpak
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Sergio Villar Senin
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2020-03-25 13:20 PDT by Sergio Villar Senin
Modified: 2020-03-26 08:26 PDT (History)
5 users (show)

See Also:

Attachments
Patch (1.68 KB, patch)
2020-03-25 13:26 PDT, Sergio Villar Senin 		no flags Details | Formatted Diff | Diff
Patch (2.18 KB, patch)
2020-03-26 07:55 PDT, Philippe Normand 		zan: review+
Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Sergio Villar Senin 2020-03-25 13:20:15 PDT 
[Flatpak] Pass all the arguments of build-webkit to webkit-flatpak
Comment 1 Sergio Villar Senin 2020-03-25 13:26:15 PDT 
Created attachment 394537 [details]
Patch
Comment 2 Philippe Normand 2020-03-26 02:38:11 PDT 
Comment on attachment 394537 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=394537&action=review

> Tools/Scripts/webkitdirs.pm:2100
> -    exec @command, argumentsForConfiguration(), "--command", @_, argumentsForConfiguration(), @ARGV or die;
> +    exec @command, argumentsForConfiguration(), @ARGV, "--command", @_, argumentsForConfiguration(), @ARGV or die;

run-minibrowser --gtk --help now show's webkit-flatpak help instead of MiniBrowser`s :(
Comment 3 Philippe Normand 2020-03-26 07:55:31 PDT 
Created attachment 394609 [details]
Patch
Comment 4 Philippe Normand 2020-03-26 08:25:20 PDT 
Committed r259045: <https://trac.webkit.org/changeset/259045>
Comment 5 Radar WebKit Bug Importer 2020-03-26 08:26:14 PDT 
<rdar://problem/60920052>