RESOLVED FIXED 209550
[ews] commit-queue should comment on bug if it fails to find any modified ChangeLog 
https://bugs.webkit.org/show_bug.cgi?id=209550
Summary [ews] commit-queue should comment on bug if it fails to find any modified Cha...
Aakash Jain
Reported 2020-03-25 10:34:46 PDT
commit-queue should comment on bug if it fails to find any modified ChangeLog.
Attachments
Patch (5.61 KB, patch)
2020-03-25 10:36 PDT, Aakash Jain 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Aakash Jain
Comment 1 2020-03-25 10:36:38 PDT
Created attachment 394516 [details] Patch
Jonathan Bedard
Comment 2 2020-03-25 11:08:41 PDT
Comment on attachment 394516 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=394516&action=review > Tools/BuildSlaveSupport/ews-build/steps.py:2491 > + if self.getProperty('buildername', '').lower() == 'commit-queue': I'm r+ing this, but I feel like we've had this pattern a few different places. I wonder if we have justification for a more general 'write comment if commit queue' function, because I think this is the 3rd time we've done this recently.
Aakash Jain
Comment 3 2020-03-25 11:19:15 PDT
Comment on attachment 394516 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=394516&action=review >> Tools/BuildSlaveSupport/ews-build/steps.py:2491 >> + if self.getProperty('buildername', '').lower() == 'commit-queue': > > I'm r+ing this, but I feel like we've had this pattern a few different places. I wonder if we have justification for a more general 'write comment if commit queue' function, because I think this is the 3rd time we've done this recently. We can look into it, but probably not worth the effort. This is probably the last one in the series.
EWS
Comment 4 2020-03-25 11:24:36 PDT
Committed r258999: <https://trac.webkit.org/changeset/258999> All reviewed patches have been landed. Closing bug and clearing flags on attachment 394516 [details].
Radar WebKit Bug Importer
Comment 5 2020-03-25 11:25:16 PDT
<rdar://problem/60881407>
Note You need to log in before you can comment on or make changes to this bug.