Bug 209524 - Introduce @tryGetByIdWithWellKnownSymbol instead of repurposing @tryGetById itself
Summary: Introduce @tryGetByIdWithWellKnownSymbol instead of repurposing @tryGetById i...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: JavaScriptCore (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Ross Kirsling
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2020-03-24 17:05 PDT by Ross Kirsling
Modified: 2020-03-24 19:08 PDT (History)
9 users (show)

See Also:

Attachments
Patch (4.60 KB, patch)
2020-03-24 17:13 PDT, Ross Kirsling 		no flags Details | Formatted Diff | Diff
Patch for landing (4.62 KB, patch)
2020-03-24 18:41 PDT, Ross Kirsling 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Ross Kirsling 2020-03-24 17:05:05 PDT 
Introduce @tryGetByIdWithWellKnownSymbol instead of repurposing @tryGetById itself
Comment 1 Ross Kirsling 2020-03-24 17:13:49 PDT 
Created attachment 394445 [details]
Patch
Comment 2 Saam Barati 2020-03-24 17:16:34 PDT 
Comment on attachment 394445 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=394445&action=review

> Source/JavaScriptCore/bytecompiler/NodesCodegen.cpp:1441
> +    ASSERT(symbol);

seems like we should release assert
Comment 3 Saam Barati 2020-03-24 17:16:45 PDT 
r=me. nice
Comment 4 Yusuke Suzuki 2020-03-24 17:17:53 PDT 
r=me too if EWS gets green :)
Comment 5 Ross Kirsling 2020-03-24 18:41:04 PDT 
Created attachment 394456 [details]
Patch for landing
Comment 6 EWS 2020-03-24 19:07:45 PDT 
Committed r258968: <https://trac.webkit.org/changeset/258968>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 394456 [details].
Comment 7 Radar WebKit Bug Importer 2020-03-24 19:08:16 PDT 
<rdar://problem/60853767>