Bug 209509 - Ignore in-app browser privacy checks for apps with com.apple.private.applemediaservices entitlement
Summary: Ignore in-app browser privacy checks for apps with com.apple.private.applemed...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit Misc. (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Kate Cheney
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2020-03-24 15:16 PDT by Kate Cheney
Modified: 2020-03-24 16:51 PDT (History)
1 user (show)

See Also:


Attachments
Patch (3.04 KB, patch)
2020-03-24 15:23 PDT, Kate Cheney
no flags Details | Formatted Diff | Diff
Patch (3.07 KB, patch)
2020-03-24 15:29 PDT, Kate Cheney
no flags Details | Formatted Diff | Diff
Patch (3.06 KB, patch)
2020-03-24 15:51 PDT, Kate Cheney
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Kate Cheney 2020-03-24 15:16:39 PDT
These applications do not need the additional quirks provided by the in-app browser privacy checks.
Comment 1 Kate Cheney 2020-03-24 15:17:00 PDT
<rdar://problem/60750956>
Comment 2 Kate Cheney 2020-03-24 15:23:57 PDT
Created attachment 394423 [details]
Patch
Comment 3 Kate Cheney 2020-03-24 15:29:59 PDT
Created attachment 394425 [details]
Patch
Comment 4 Brent Fulgham 2020-03-24 15:44:52 PDT
Comment on attachment 394425 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=394425&action=review

Looks great! Just fix the include before landing.

> Source/WebKit/UIProcess/WebPageProxy.cpp:186
> +#include <wtf/cocoa/Entitlements.h>

This needs to be inside the #if PLATFORM(COCOA)
Comment 5 Kate Cheney 2020-03-24 15:51:11 PDT
Created attachment 394428 [details]
Patch
Comment 6 Kate Cheney 2020-03-24 15:51:38 PDT
Thanks! Just going to make sure this compiles on gtk before landing.
Comment 7 Brent Fulgham 2020-03-24 15:56:36 PDT
Comment on attachment 394428 [details]
Patch

Perfect! r=me
Comment 8 EWS 2020-03-24 16:51:11 PDT
Committed r258958: <https://trac.webkit.org/changeset/258958>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 394428 [details].