Bug 209507 - Fix isEmpty AssemblyHelpers function and add isNotEmpty
Summary: Fix isEmpty AssemblyHelpers function and add isNotEmpty
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Keith Miller
URL:
Keywords: InRadar
: 209505 (view as bug list)
Depends on:
Blocks:
 
Reported: 2020-03-24 15:04 PDT by Keith Miller
Modified: 2020-03-24 15:54 PDT (History)
7 users (show)

See Also:

Attachments
Patch (2.63 KB, patch)
2020-03-24 15:06 PDT, Keith Miller 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Keith Miller 2020-03-24 15:04:56 PDT 
Fix isEmpty AssemblyHelpers function and add isNotEmpty
Comment 1 Keith Miller 2020-03-24 15:06:07 PDT 
Created attachment 394418 [details]
Patch
Comment 2 Caio Lima 2020-03-24 15:24:29 PDT 
Comment on attachment 394418 [details]
Patch

LGTM as well. I tested it locally and it is passing all 189 failing tests
Comment 3 Caio Lima 2020-03-24 15:26:34 PDT 
*** Bug 209505 has been marked as a duplicate of this bug. ***
Comment 4 EWS 2020-03-24 15:53:09 PDT 
Committed r258952: <https://trac.webkit.org/changeset/258952>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 394418 [details].
Comment 5 Radar WebKit Bug Importer 2020-03-24 15:54:14 PDT 
<rdar://problem/60845969>