Bug 209491 – [ Mac ] fast/animation/request-animation-frame-cancel2.html is flaky failing.

• Status: RESOLVED
• Resolution: FIXED
• Component: Animations

[Jason Lawrence]

fast/animation/request-animation-frame-cancel2.html 

Description:
This test is flaky failing on Mac. It's flaky failing throughout the visible history.


History:
https://results.webkit.org/?suite=layout-tests&test=fast%2Fanimation%2Frequest-animation-frame-cancel2.html&platform=mac&limit=50000

Diff:
--- /Volumes/Data/slave/catalina-release-tests-wk2/build/layout-test-results/fast/animation/request-animation-frame-cancel2-expected.txt
+++ /Volumes/Data/slave/catalina-release-tests-wk2/build/layout-test-results/fast/animation/request-animation-frame-cancel2-actual.txt
@@ -4,7 +4,7 @@
 
 
 PASS callbackFired is false
-PASS cancelFired is true
+FAIL cancelFired should be true. Was false.
 PASS successfullyParsed is true
 
 TEST COMPLETE

[Radar WebKit Bug Importer]

<rdar://problem/60838901>

[Jason Lawrence]

I have marked this test as failing while this issue is investigated.
https://trac.webkit.org/changeset/258935/webkit

[Jason Lawrence]

I can reproduce this issue with r258908 by running the command below.
run-webkit-tests --iterations 888 --child-processes 50 --force -f fast/animation/request-animation-frame-cancel2.html -g

819 tests ran as expected, 69 didn't:

[Said Abou-Hallawa]

Created attachment 398491 [details]
Patch

[Antoine Quint]

Comment on attachment 398491 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=398491&action=review

> LayoutTests/fast/animation/request-animation-frame-cancel2.html:10
> +    var e = document.getElementById("e");

Technically you're redefining `e` here because `window.e` was already defined to be that element. It's kinda dirty, but that's the Web :)

I'm not sure what is the use of this variable though, you seem to use it only as the second parameter to requestAnimationFrame() calls and that method only takes a single parameter.

> LayoutTests/fast/animation/request-animation-frame-cancel2.html:16
> +            window.requestAnimationFrame(function(timestamp) {

You're mixing arrow-syntax and `function`, could you use a consistent style?

> LayoutTests/fast/animation/request-animation-frame-cancel2.html:20
> +            }, e);

What is this second parameter to requestAnimationFrame?

> LayoutTests/fast/animation/request-animation-frame-cancel2.html:29
> +            }, e);

What is this second parameter to requestAnimationFrame?

> LayoutTests/fast/animation/request-animation-frame-cancel2.html:32
> +            setTimeout(function() {
> +                resolve();
> +            }, 100);

setTimeout(resolve, 100);

[Said Abou-Hallawa]

Created attachment 398522 [details]
Patch

[Said Abou-Hallawa]

Created attachment 398526 [details]
Patch

[EWS]

Committed r261186: <https://trac.webkit.org/changeset/261186>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 398526 [details].