Bug 209488 - Memory::fastMappedBytes() is wrong
Summary: Memory::fastMappedBytes() is wrong
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: JavaScriptCore (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Saam Barati
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2020-03-24 12:48 PDT by Saam Barati
Modified: 2020-03-24 17:29 PDT (History)
10 users (show)

See Also:


Attachments
patch (1.38 KB, patch)
2020-03-24 16:53 PDT, Saam Barati
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Saam Barati 2020-03-24 12:48:04 PDT
....
Comment 1 Saam Barati 2020-03-24 12:48:12 PDT
it's off by 1
Comment 2 Saam Barati 2020-03-24 16:53:54 PDT
Created attachment 394441 [details]
patch
Comment 3 Mark Lam 2020-03-24 17:03:41 PDT
Comment on attachment 394441 [details]
patch

r=me.  This code is not compiled on 32-bit targets, right?
Comment 4 Saam Barati 2020-03-24 17:06:13 PDT
(In reply to Mark Lam from comment #3)
> Comment on attachment 394441 [details]
> patch
> 
> r=me.  This code is not compiled on 32-bit targets, right?

correct. Wasm is 64-bit only
Comment 5 EWS 2020-03-24 17:28:02 PDT
Committed r258964: <https://trac.webkit.org/changeset/258964>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 394441 [details].
Comment 6 Radar WebKit Bug Importer 2020-03-24 17:29:13 PDT
<rdar://problem/60850158>