Bug 209478 - [GTK][WPE] WEB_PROCESS_CMD_PREFIX and others have stopped working
Summary: [GTK][WPE] WEB_PROCESS_CMD_PREFIX and others have stopped working
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Chris Lord
Keywords: InRadar
Depends on:
Reported: 2020-03-24 08:14 PDT by Chris Lord
Modified: 2020-03-24 08:47 PDT (History)
5 users (show)

See Also:

Patch (1.40 KB, patch)
2020-03-24 08:19 PDT, Chris Lord
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Chris Lord 2020-03-24 08:14:20 PDT
This was caused by the switch to Flatpak dependencies, which now sandboxes the environment. These variables need to be white-listed.
Comment 1 Chris Lord 2020-03-24 08:19:24 PDT
Created attachment 394367 [details]
Comment 2 Philippe Normand 2020-03-24 08:22:21 PDT
Comment on attachment 394367 [details]

View in context: https://bugs.webkit.org/attachment.cgi?id=394367&action=review

> Tools/ChangeLog:6
> +        Make sure *_PROCESS_CMD_PREFIX variables are whitelisted in the Flatpak sandbox.

An alternative could have been to add this to `env_var_suffixes_to_keep` but I'm also OK with this approach. Explicit is better than implicit usually :)
Comment 3 Chris Lord 2020-03-24 08:25:26 PDT
Comment on attachment 394367 [details]

I agree with explicit being better (though maybe I'll disagree when this comes back and bites us again ;)) so leaving as is.

It would be good if these variables had 'WEBKIT' somewhere in them I think, if we were going to whitelist the suffix.
Comment 4 Philippe Normand 2020-03-24 08:37:46 PDT
Yeah, or a WEBKIT_ prefix :)
Comment 5 EWS 2020-03-24 08:46:52 PDT
Committed r258910: <https://trac.webkit.org/changeset/258910>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 394367 [details].
Comment 6 Radar WebKit Bug Importer 2020-03-24 08:47:14 PDT