Bug 209477 - [Slack] the #changes channel is too noisy and uncurated
Summary: [Slack] the #changes channel is too noisy and uncurated
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Yusuke Suzuki
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2020-03-24 08:11 PDT by Philippe Normand
Modified: 2020-05-30 23:28 PDT (History)
7 users (show)

See Also:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Philippe Normand 2020-03-24 08:11:35 PDT
It would be great to have messages sent to that channel in a format similar to what the WKR IRC bot was using.
Comment 1 Alexey Proskuryakov 2020-03-24 09:01:48 PDT
I've been told that this is just showing RSS feed from Trac. Feedback accepted and I would personally also prefer a more compact format, but this would be a replacement, not adjustment.
Comment 2 Aakash Jain 2020-03-24 09:18:47 PDT
Yeah. Seems like it gets the RSS feed from this url: https://trac.webkit.org/timeline?changeset=on&wiki=on&max=50&authors=&daysback=90&format=rss
Comment 3 Jonathan Bedard 2020-03-24 09:28:19 PDT
Are we looking for something like this: https://results.webkit.org/commits? (with the one-line toggle)

I feel like WKR IRC bot basically spat out single lines, but I don't exactly remember
Comment 4 Philippe Normand 2020-03-24 09:31:03 PDT
Here's an example, from the good old times:

<WKR> https://trac.webkit.org/r258848 by Devin Rousso (drousso) Web Inspector: Uncaught Exception: TypeError: this._springEditor.removeListeners is not a function. (In 'this._springEditor.removeListeners()', 'this._springEditor.removeListeners' is undefined) https://webkit.org/b/209325 Reviewed by Brian Burg (bburg).
Comment 5 Philippe Normand 2020-03-24 09:33:37 PDT
So somethings like:

<trac commit link> by <author fullname + handle/nickname> <commit headline, probably clipped to an acceptable amount of characters> <bugzilla link> Reviewed by <reviewer fullname + handle/nickname>
Comment 6 Aakash Jain 2020-03-24 10:23:09 PDT
(In reply to Philippe Normand from comment #5)
> <trac commit link> by <author fullname + handle/nickname> <commit headline, probably clipped to an acceptable amount of characters> <bugzilla link> Reviewed by <reviewer fullname + handle/nickname>

The code to generate this message is in: https://trac.webkit.org/browser/webkit/trunk/Tools/Scripts/webkitpy/tool/commands/newcommitbot.py#L115 : _summarize_commit_log()
Comment 7 Yusuke Suzuki 2020-04-07 10:56:58 PDT
As a first step, I've just connected github.com/WebKit/webkit's commits to #changes channel instead of using RSS from trac.webkit.org. Let's see how it is formatted in slack. If this is not desirable, we could change it in detailed way by using web-hook based approach (webhook from github.com/WebKit/webkit to slack).
Comment 8 Yusuke Suzuki 2020-05-30 23:28:00 PDT
I think this is now changed.
Comment 9 Radar WebKit Bug Importer 2020-05-30 23:28:15 PDT
<rdar://problem/63803716>