Bug 20946 - REGRESSION: Invalid CSS @media query should be ignored but isn't
Summary: REGRESSION: Invalid CSS @media query should be ignored but isn't
Status: RESOLVED INVALID
Alias: None
Product: WebKit
Classification: Unclassified
Component: CSS (show other bugs)
Version: 528+ (Nightly build)
Hardware: Mac OS X 10.5
: P1 Major
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2008-09-19 12:21 PDT by Chris Petersen
Modified: 2009-01-06 00:06 PST (History)
2 users (show)

See Also:

Attachments
Reduced test case (203 bytes, text/html)
2008-09-19 12:22 PDT, Chris Petersen 		no flags Details
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Chris Petersen 2008-09-19 12:21:24 PDT 
* SUMMARY
With Webkit NB r36640 , a invalid CSS @media query should be ignored but isn't. This problem was originally found at http://store.iomega.com/section?SID=f2e44e869a9564289240548cef0a492cc48:4760&secid=40299.

I have reduced it down with Tim H to a simple test case.

<style>
.test {
	background-color: green;
	width: 20px;
	height: 20px;
}

@media screen {

/* Any style rules after this will be ignored. */

.test {
	display: none;
}
</style>

<div class="test"></div>

* STEPS TO REPRODUCE
1. Open the attached file "iomega.html" in Safari 3.1.
2. Notice a green square (< DIV> ) appears on this page
3. Now, open this same test case in TOT. Notice the green square doesn't appear on the page at all.

The display: none; rule is being processed even thought it shouldn't be ( since the @media query is not valid)
Comment 1 Chris Petersen 2008-09-19 12:22:09 PDT 
Created attachment 23577 [details]
Reduced test case
Comment 2 Chris Petersen 2008-09-19 12:22:53 PDT 
<rdar://problem/6232970>
Comment 3 Anatoli Papirovski 2008-12-11 13:31:31 PST 
The @media query is valid! See here http://www.w3.org/TR/CSS21/syndata.html#parsing-errors - specifically the section about "Unexpected end of style sheet".
Comment 4 Anatoli Papirovski 2008-12-11 13:33:48 PST 
More information: Firefox 3 gets this wrong, Opera 9.5 gets it right.
Comment 5 Robert Blaut 2009-01-06 00:06:12 PST 
(In reply to comment #3)
> The @media query is valid! See here
> http://www.w3.org/TR/CSS21/syndata.html#parsing-errors - specifically the
> section about "Unexpected end of style sheet".
> 

I agree with Anatoli. The reported style sheet is absolutely correct.

(In reply to comment #4)
> More information: Firefox 3 gets this wrong, Opera 9.5 gets it right.
> 

Firefox 3.1 beta 2 has this bug fixed. 

I close this bug as INVALID since it doesn't describe a real bug.