Bug 209449 – Update test262 to commit 79146e5cf48d

• Status: RESOLVED
• Resolution: FIXED
• Component: JavaScriptCore

[Alexey Shvayka]

Update test262 to commit 79146e5cf48d

[Alexey Shvayka]

Created attachment 394324 [details]
Patch

[Alexey Shvayka]

(In reply to Alexey Shvayka from comment #1)
> Created attachment 394324 [details]
> Patch

There are 3 tests that timeout.
I will fix related bugs in a short time, yet we should consider setting default --timeout to a large finite value.

[Keith Miller]

(In reply to Alexey Shvayka from comment #2)
> (In reply to Alexey Shvayka from comment #1)
> > Created attachment 394324 [details]
> > Patch
> 
> There are 3 tests that timeout.
> I will fix related bugs in a short time, yet we should consider setting
> default --timeout to a large finite value.

Do you know why they timeout?

[Alexey Shvayka]

(In reply to Keith Miller from comment #3)
> Do you know why they timeout?

Yes, timeouts are intentional: there were no way to author those tests so they would fail with an exception instead of timing out.

[Alexey Shvayka]

There are quite a few skipped Array.prototype tests because of timeouts, please see https://trac.webkit.org/browser/webkit/trunk/JSTests/test262/config.yaml#L85.

Most of them will be fixed with https://bugs.webkit.org/show_bug.cgi?id=163417.

[Keith Miller]

(In reply to Alexey Shvayka from comment #4)
> (In reply to Keith Miller from comment #3)
> > Do you know why they timeout?
> 
> Yes, timeouts are intentional: there were no way to author those tests so
> they would fail with an exception instead of timing out.

Ah, ok. Tests seem a little contrived but sure.

[Keith Miller]

Comment on attachment 394324 [details]
Patch

rs=me

[EWS]

Committed r258943: <https://trac.webkit.org/changeset/258943>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 394324 [details].

[Radar WebKit Bug Importer]

<rdar://problem/60843677>

[Truitt Savell]

It looks like the changes in https://trac.webkit.org/changeset/258943/webkit

broke 4 test262 tests

Build:
https://build.webkit.org/builders/Apple-Catalina-Debug-Test262-Tests/builds/2358

Log file:
https://build.webkit.org/builders/Apple-Catalina-Debug-Test262-Tests/builds/2358/steps/test262-test/logs/stdio

[Alexey Shvayka]

Committed r258963: <https://trac.webkit.org/changeset/258963>

[Ross Kirsling]

(In reply to Alexey Shvayka from comment #11)
> Committed r258963: <https://trac.webkit.org/changeset/258963>

Somehow as of this second commit, test/language/global-code/decl-lex-configurable-global.js is now failing, but it appears that you've already fixed this upstream in https://github.com/tc39/test262/pull/2546, so I guess we just need to sync yet again? :P

[Ross Kirsling]

(In reply to Ross Kirsling from comment #12)
> Somehow as of this second commit,
> test/language/global-code/decl-lex-configurable-global.js is now failing,
> but it appears that you've already fixed this upstream in
> https://github.com/tc39/test262/pull/2546, so I guess we just need to sync
> yet again? :P

Committed r259032: <https://trac.webkit.org/changeset/259032>