Bug 209444 – Add console message when legacy TLS is used

• Status: RESOLVED
• Resolution: FIXED
• Component: New Bugs

[Alex Christensen]

Add console message when legacy TLS is used

[Alex Christensen]

Created attachment 394314 [details]
Patch

[Darin Adler]

Comment on attachment 394314 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=394314&action=review

> Source/WebCore/loader/ResourceLoader.cpp:511
>                  document->setUsedLegacyTLS(true);

Could have put that inside the braces.

[Alex Christensen]

Created attachment 394320 [details]
Patch

[Alex Christensen]

Comment on attachment 394320 [details]
Patch

Done.  I also removed the host from the logs.

[Darin Adler]

Comment on attachment 394320 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=394320&action=review

> Source/WebCore/loader/ResourceLoader.cpp:509
> +                        page->console().addMessage(MessageSource::Network, MessageLevel::Warning, "Loaded resource using TLS 1.0 or 1.1, which are deprecated protocols that will be removed.  Please use TLS 1.2 or newer instead."_s, 0, document);

Two spaces after a period!? Not sure what our style is, but I never do that.

[Alex Christensen]

Created attachment 394321 [details]
Patch

[Alex Christensen]

Our style doesn't seem to care.  I've done it consistently since elementary school unless told otherwise, but I removed it here.

[EWS]

Committed r258890: <https://trac.webkit.org/changeset/258890>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 394321 [details].

[Radar WebKit Bug Importer]

<rdar://problem/60800462>

[Darin Adler]

Comment on attachment 394321 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=394321&action=review

> Source/WebCore/loader/ResourceLoader.cpp:505
>      if (r.usedLegacyTLS()) {
>          if (m_frame) {

Just noticed we could indent this a little bit less by using && here.

[Alex Christensen]

Reopening to attach new patch.

[Alex Christensen]

Created attachment 394380 [details]
Patch

[EWS]

commit-queue failed to commit attachment 394380 [details] to WebKit repository.

[Aakash Jain]

(In reply to EWS from comment #13)
> commit-queue failed to commit attachment 394380 [details] to WebKit repository.
There was another commit (modifying same ChangeLog) https://trac.webkit.org/r258916 almost at the same time when commit-queue tried to land this. Please cq+ again.

[EWS]

Committed r258957: <https://trac.webkit.org/changeset/258957>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 394380 [details].