Bug 209423 – [Web Animations] Refactor cancelDeclarativeAnimationsForElement and willDestroyRendererForElement on AnimationTimeline

• Status: RESOLVED
• Resolution: FIXED
• Component: Animations

[Antoine Quint]

[Web Animations] Refactor cancelDeclarativeAnimationsForElement and willDestroyRendererForElement on AnimationTimeline

[Antoine Quint]

Created attachment 394259 [details]
Patch

[Antti Koivisto]

Comment on attachment 394259 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=394259&action=review

> Source/WebCore/animation/WebAnimation.h:96
> +    virtual void cancel(Silently = Silently::No);

Maybe Silently could be renamed to something more descriptive?

enum class CancelType { CompletePromises, DontCompletePromises }

or whatever the appropriate terminology is?

[Antoine Quint]

(In reply to Antti Koivisto from comment #2)
> Comment on attachment 394259 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=394259&action=review
> 
> > Source/WebCore/animation/WebAnimation.h:96
> > +    virtual void cancel(Silently = Silently::No);
> 
> Maybe Silently could be renamed to something more descriptive?
> 
> enum class CancelType { CompletePromises, DontCompletePromises }
> 
> or whatever the appropriate terminology is?

After discussing directly with Antti, we figured that because this did not involve just promise rejection, but dispatch of the "cancel" event and timeline notification, that the "Silently" term was not so bad after all and would keep it as-is.

[Antoine Quint]

Committed r258842: <https://trac.webkit.org/changeset/258842>

[Radar WebKit Bug Importer]

<rdar://problem/60774456>