Bug 209423 - [Web Animations] Refactor cancelDeclarativeAnimationsForElement and willDestroyRendererForElement on AnimationTimeline
Summary: [Web Animations] Refactor cancelDeclarativeAnimationsForElement and willDestr...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Animations (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Antoine Quint
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2020-03-23 06:44 PDT by Antoine Quint
Modified: 2020-03-23 07:42 PDT (History)
8 users (show)

See Also:


Attachments
Patch (8.68 KB, patch)
2020-03-23 06:47 PDT, Antoine Quint
koivisto: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Antoine Quint 2020-03-23 06:44:16 PDT
[Web Animations] Refactor cancelDeclarativeAnimationsForElement and willDestroyRendererForElement on AnimationTimeline
Comment 1 Antoine Quint 2020-03-23 06:47:04 PDT
Created attachment 394259 [details]
Patch
Comment 2 Antti Koivisto 2020-03-23 06:54:56 PDT
Comment on attachment 394259 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=394259&action=review

> Source/WebCore/animation/WebAnimation.h:96
> +    virtual void cancel(Silently = Silently::No);

Maybe Silently could be renamed to something more descriptive?

enum class CancelType { CompletePromises, DontCompletePromises }

or whatever the appropriate terminology is?
Comment 3 Antoine Quint 2020-03-23 07:05:49 PDT
(In reply to Antti Koivisto from comment #2)
> Comment on attachment 394259 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=394259&action=review
> 
> > Source/WebCore/animation/WebAnimation.h:96
> > +    virtual void cancel(Silently = Silently::No);
> 
> Maybe Silently could be renamed to something more descriptive?
> 
> enum class CancelType { CompletePromises, DontCompletePromises }
> 
> or whatever the appropriate terminology is?

After discussing directly with Antti, we figured that because this did not involve just promise rejection, but dispatch of the "cancel" event and timeline notification, that the "Silently" term was not so bad after all and would keep it as-is.
Comment 4 Antoine Quint 2020-03-23 07:41:14 PDT
Committed r258842: <https://trac.webkit.org/changeset/258842>
Comment 5 Radar WebKit Bug Importer 2020-03-23 07:42:17 PDT
<rdar://problem/60774456>