RESOLVED FIXED 209390
[LFC] Box::establishesBlockFormattingContext should check isInitialContainingBlock 
https://bugs.webkit.org/show_bug.cgi?id=209390
Summary [LFC] Box::establishesBlockFormattingContext should check isInitialContaining...
zalan
Reported 2020-03-21 21:52:35 PDT
and not !parent().
Attachments
Patch (2.10 KB, patch)
2020-03-21 22:00 PDT, zalan 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Radar WebKit Bug Importer
Comment 1 2020-03-21 21:53:35 PDT
<rdar://problem/60735021>
zalan
Comment 2 2020-03-21 22:00:24 PDT
Created attachment 394193 [details] Patch
Antti Koivisto
Comment 3 2020-03-22 06:50:29 PDT
Comment on attachment 394193 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=394193&action=review > Source/WebCore/layout/layouttree/LayoutBox.cpp:74 > + if (isInitialContainingBlock()) > return true; Maybe ASSERT(parent()) after?
zalan
Comment 4 2020-03-22 07:02:31 PDT
(In reply to Antti Koivisto from comment #3) > Comment on attachment 394193 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=394193&action=review > > > Source/WebCore/layout/layouttree/LayoutBox.cpp:74 > > + if (isInitialContainingBlock()) > > return true; > > Maybe ASSERT(parent()) after? In the upcoming patch, parent() is going to return const Container&.
EWS
Comment 5 2020-03-23 07:22:10 PDT
Committed r258836: <https://trac.webkit.org/changeset/258836> All reviewed patches have been landed. Closing bug and clearing flags on attachment 394193 [details].
Note You need to log in before you can comment on or make changes to this bug.