Bug 209390 - [LFC] Box::establishesBlockFormattingContext should check isInitialContainingBlock
Summary: [LFC] Box::establishesBlockFormattingContext should check isInitialContaining...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Layout and Rendering (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: zalan
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2020-03-21 21:52 PDT by zalan
Modified: 2020-03-23 07:22 PDT (History)
5 users (show)

See Also:

Attachments
Patch (2.10 KB, patch)
2020-03-21 22:00 PDT, zalan 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description zalan 2020-03-21 21:52:35 PDT 
and not !parent().
Comment 1 Radar WebKit Bug Importer 2020-03-21 21:53:35 PDT 
<rdar://problem/60735021>
Comment 2 zalan 2020-03-21 22:00:24 PDT 
Created attachment 394193 [details]
Patch
Comment 3 Antti Koivisto 2020-03-22 06:50:29 PDT 
Comment on attachment 394193 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=394193&action=review

> Source/WebCore/layout/layouttree/LayoutBox.cpp:74
> +    if (isInitialContainingBlock())
>          return true;

Maybe ASSERT(parent()) after?
Comment 4 zalan 2020-03-22 07:02:31 PDT 
(In reply to Antti Koivisto from comment #3)
> Comment on attachment 394193 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=394193&action=review
> 
> > Source/WebCore/layout/layouttree/LayoutBox.cpp:74
> > +    if (isInitialContainingBlock())
> >          return true;
> 
> Maybe ASSERT(parent()) after?
In the upcoming patch, parent() is going to return const Container&.
Comment 5 EWS 2020-03-23 07:22:10 PDT 
Committed r258836: <https://trac.webkit.org/changeset/258836>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 394193 [details].