Bug 209389 – Web Inspector: use native datetime-local picker for changing `expires` value in cookie popover

• Status: RESOLVED
• Resolution: FIXED
• Component: Web Inspector

[Devin Rousso]

Rather than have a `<input type="text">` that we `Date.parse` on each `"input"`, using a `<input type="datetime-local">` would be preferred.

[Devin Rousso]

Created attachment 423418 [details]
Patch

[Blaze Burg]

Comment on attachment 423418 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=423418&action=review

> Source/WebInspectorUI/UserInterface/Views/CookiePopover.js:135
> +            data.expires = formatDate(cookie.expires || this._defaultExpires());

Maybe I'm missing something, but will this regress localized date formatting? Is this something the datetime picker is responsible for now?

[Devin Rousso]

Comment on attachment 423418 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=423418&action=review

>> Source/WebInspectorUI/UserInterface/Views/CookiePopover.js:135
>> +            data.expires = formatDate(cookie.expires || this._defaultExpires());
> 
> Maybe I'm missing something, but will this regress localized date formatting? Is this something the datetime picker is responsible for now?

AFAIU this is the format expected by `<input type="datetime-local">` according to @Aditya Keerthi.  The "local" part of "datetime-local" means that it will always be based on the local time.

[Blaze Burg]

Comment on attachment 423418 [details]
Patch

r=me. We may get pushback if this breaks localizations.

[EWS]

Committed r274593: <https://commits.webkit.org/r274593>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 423418 [details].

[Radar WebKit Bug Importer]

<rdar://problem/75545445>