RESOLVED FIXED 209389
Web Inspector: use native datetime-local picker for changing `expires` value in cookie popover
https://bugs.webkit.org/show_bug.cgi?id=209389
Summary Web Inspector: use native datetime-local picker for changing `expires` value ...
Devin Rousso
Reported 2020-03-21 19:52:37 PDT
Rather than have a `<input type="text">` that we `Date.parse` on each `"input"`, using a `<input type="datetime-local">` would be preferred.
Attachments
Patch (4.38 KB, patch)
2021-03-16 17:05 PDT, Devin Rousso
no flags
Devin Rousso
Comment 1 2021-03-16 17:05:49 PDT
Blaze Burg
Comment 2 2021-03-17 12:06:18 PDT
Comment on attachment 423418 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=423418&action=review > Source/WebInspectorUI/UserInterface/Views/CookiePopover.js:135 > + data.expires = formatDate(cookie.expires || this._defaultExpires()); Maybe I'm missing something, but will this regress localized date formatting? Is this something the datetime picker is responsible for now?
Devin Rousso
Comment 3 2021-03-17 12:16:19 PDT
Comment on attachment 423418 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=423418&action=review >> Source/WebInspectorUI/UserInterface/Views/CookiePopover.js:135 >> + data.expires = formatDate(cookie.expires || this._defaultExpires()); > > Maybe I'm missing something, but will this regress localized date formatting? Is this something the datetime picker is responsible for now? AFAIU this is the format expected by `<input type="datetime-local">` according to @Aditya Keerthi. The "local" part of "datetime-local" means that it will always be based on the local time.
Blaze Burg
Comment 4 2021-03-17 14:53:18 PDT
Comment on attachment 423418 [details] Patch r=me. We may get pushback if this breaks localizations.
EWS
Comment 5 2021-03-17 14:59:52 PDT
Committed r274593: <https://commits.webkit.org/r274593> All reviewed patches have been landed. Closing bug and clearing flags on attachment 423418 [details].
Radar WebKit Bug Importer
Comment 6 2021-03-17 15:01:19 PDT
Note You need to log in before you can comment on or make changes to this bug.