Bug 209389 - Web Inspector: use native datetime-local picker for changing `expires` value in cookie popover
Summary: Web Inspector: use native datetime-local picker for changing `expires` value ...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (show other bugs)
Version: WebKit Local Build
Hardware: All All
: P2 Normal
Assignee: Devin Rousso
URL:
Keywords: InRadar
Depends on: 31157 119175
Blocks:
  Show dependency tree / graph
 
Reported: 2020-03-21 19:52 PDT by Devin Rousso
Modified: 2021-03-17 15:01 PDT (History)
6 users (show)

See Also:

Attachments
Patch (4.38 KB, patch)
2021-03-16 17:05 PDT, Devin Rousso 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Devin Rousso 2020-03-21 19:52:37 PDT 
Rather than have a `<input type="text">` that we `Date.parse` on each `"input"`, using a `<input type="datetime-local">` would be preferred.
Comment 1 Devin Rousso 2021-03-16 17:05:49 PDT 
Created attachment 423418 [details]
Patch
Comment 2 BJ Burg 2021-03-17 12:06:18 PDT 
Comment on attachment 423418 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=423418&action=review

> Source/WebInspectorUI/UserInterface/Views/CookiePopover.js:135
> +            data.expires = formatDate(cookie.expires || this._defaultExpires());

Maybe I'm missing something, but will this regress localized date formatting? Is this something the datetime picker is responsible for now?
Comment 3 Devin Rousso 2021-03-17 12:16:19 PDT 
Comment on attachment 423418 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=423418&action=review

>> Source/WebInspectorUI/UserInterface/Views/CookiePopover.js:135
>> +            data.expires = formatDate(cookie.expires || this._defaultExpires());
> 
> Maybe I'm missing something, but will this regress localized date formatting? Is this something the datetime picker is responsible for now?

AFAIU this is the format expected by `<input type="datetime-local">` according to @Aditya Keerthi.  The "local" part of "datetime-local" means that it will always be based on the local time.
Comment 4 BJ Burg 2021-03-17 14:53:18 PDT 
Comment on attachment 423418 [details]
Patch

r=me. We may get pushback if this breaks localizations.
Comment 5 EWS 2021-03-17 14:59:52 PDT 
Committed r274593: <https://commits.webkit.org/r274593>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 423418 [details].
Comment 6 Radar WebKit Bug Importer 2021-03-17 15:01:19 PDT 
<rdar://problem/75545445>