Bug 209381 - [LFC] Layout::Box::containingBlock should return a const ContainerBox&
Summary: [LFC] Layout::Box::containingBlock should return a const ContainerBox&
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Layout and Rendering (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: zalan
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2020-03-21 17:41 PDT by zalan
Modified: 2020-03-22 07:02 PDT (History)
5 users (show)

See Also:


Attachments
Patch (41.88 KB, patch)
2020-03-21 18:38 PDT, zalan
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description zalan 2020-03-21 17:41:37 PDT
and not const ContainerBox*

Layout tree is immutable during layout, so it's guaranteed to have a valid containing block.
Comment 1 Radar WebKit Bug Importer 2020-03-21 17:41:55 PDT
<rdar://problem/60732278>
Comment 2 zalan 2020-03-21 18:38:42 PDT
Created attachment 394188 [details]
Patch
Comment 3 Antti Koivisto 2020-03-22 06:49:42 PDT
Comment on attachment 394188 [details]
Patch

nice
Comment 4 EWS 2020-03-22 07:02:44 PDT
Committed r258819: <https://trac.webkit.org/changeset/258819>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 394188 [details].