Bug 209335 - [MSE][GStreamer] Clean and explain first sample PTS hack
Summary: [MSE][GStreamer] Clean and explain first sample PTS hack
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKitGTK (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Alicia Boya García
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2020-03-20 06:10 PDT by Alicia Boya García
Modified: 2020-03-23 08:27 PDT (History)
13 users (show)

See Also:


Attachments
Patch (5.54 KB, patch)
2020-03-20 10:40 PDT, Alicia Boya García
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Alicia Boya García 2020-03-20 06:10:13 PDT
MediaSample::applyPtsOffset() had a rather confusing name, so it has
been changed to something more descriptive of its actual function:
extendToTheBeginning().

Also, its only argument has been removed, as it's always zero.

An explanation of the hack has also been added.

This patch introduces no behavior changes.
Comment 1 Alicia Boya García 2020-03-20 10:40:21 PDT
Created attachment 394101 [details]
Patch
Comment 2 EWS 2020-03-23 08:27:43 PDT
Committed r258844: <https://trac.webkit.org/changeset/258844>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 394101 [details].