RESOLVED FIXED 209334
[ews] commit-queue should comment on bug if patch fails to apply 
https://bugs.webkit.org/show_bug.cgi?id=209334
Summary [ews] commit-queue should comment on bug if patch fails to apply
Aakash Jain
Reported 2020-03-20 06:05:52 PDT
commit-queue should comment on bug and set cq- if patch fails to apply.
Attachments
Patch (5.71 KB, patch)
2020-03-20 06:34 PDT, Aakash Jain 		jbedard: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Aakash Jain
Comment 1 2020-03-20 06:34:57 PDT
Created attachment 394080 [details] Patch
Jonathan Bedard
Comment 3 2020-03-20 07:24:40 PDT
Comment on attachment 394080 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=394080&action=review > Tools/BuildSlaveSupport/ews-build/steps.py:230 > + message = 'Patch {} does not apply'.format(patch_id) Shouldn't we define the message only if the return-code is a failure?
Aakash Jain
Comment 4 2020-03-20 07:31:39 PDT
Committed r258760: <https://trac.webkit.org/changeset/258760>
Aakash Jain
Comment 5 2020-03-20 07:31:59 PDT
> Shouldn't we define the message only if the return-code is a failure? Done
Radar WebKit Bug Importer
Comment 6 2020-03-20 07:32:14 PDT
<rdar://problem/60684345>
Note You need to log in before you can comment on or make changes to this bug.