209334 – [ews] commit-queue should comment on bug if patch fails to apply

Bug 209334 - [ews] commit-queue should comment on bug if patch fails to apply

Summary: [ews] commit-queue should comment on bug if patch fails to apply

Status:	RESOLVED FIXED

Alias:	None

Product:	WebKit
Classification:	Unclassified
Component:	Tools / Tests (show other bugs)
Version:	Other
Hardware:	Unspecified Unspecified

Importance:	P2 Normal
Assignee:	Aakash Jain

URL:
Keywords:	InRadar

Depends on:
Blocks:

Reported:	2020-03-20 06:05 PDT by Aakash Jain
Modified:	2020-03-20 07:32 PDT (History)
CC List:	4 users (show)

See Also:

Attachments
Patch (5.71 KB, patch) 2020-03-20 06:34 PDT, Aakash Jain	jbedard: review+	Details \| Formatted Diff \| Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.

Description Aakash Jain 2020-03-20 06:05:52 PDT

commit-queue should comment on bug and set cq- if patch fails to apply.

Comment 1 Aakash Jain 2020-03-20 06:34:57 PDT

Created attachment 394080 [details]
Patch

Comment 2 Aakash Jain 2020-03-20 06:36:20 PDT

Sample runs:

Commit-queue: https://ews-build.webkit-uat.org/#/builders/26/builds/1611
Other queue: https://ews-build.webkit-uat.org/#/builders/14/builds/934

Comment 3 Jonathan Bedard 2020-03-20 07:24:40 PDT

Comment on attachment 394080 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=394080&action=review

> Tools/BuildSlaveSupport/ews-build/steps.py:230
> +        message = 'Patch {} does not apply'.format(patch_id)

Shouldn't we define the message only if the return-code is a failure?

Comment 4 Aakash Jain 2020-03-20 07:31:39 PDT

Committed r258760: <https://trac.webkit.org/changeset/258760>

Comment 5 Aakash Jain 2020-03-20 07:31:59 PDT

> Shouldn't we define the message only if the return-code is a failure?
Done

Comment 6 Radar WebKit Bug Importer 2020-03-20 07:32:14 PDT

<rdar://problem/60684345>