Bug 209318 – REGRESSION (r258707): storage/indexeddb/cursor-leak.html is flaky timing out

• Status: RESOLVED
• Resolution: FIXED
• Component: New Bugs

[Jacob Uphoff]

storage/indexeddb/cursor-leak.html

This test started to flaky timeout after commit r258707 for wk2.

History:

https://results.webkit.org/?suite=layout-tests&test=storage%2Findexeddb%2Fcursor-leak.html

Diff:

--- /Volumes/Data/slave/catalina-release-tests-wk2/build/layout-test-results/storage/indexeddb/cursor-leak-expected.txt
+++ /Volumes/Data/slave/catalina-release-tests-wk2/build/layout-test-results/storage/indexeddb/cursor-leak-actual.txt
@@ -1,15 +1,5 @@
-Verify that that cursors weakly hold script value properties
+#PID UNRESPONSIVE - WebKitTestRunner (pid 75029)
+FAIL: Timed out waiting for notifyDone to be called
 
-On success, you will see a series of "PASS" messages, followed by "TEST COMPLETE".
-
-
-indexedDB = self.indexedDB || self.webkitIndexedDB || self.mozIndexedDB || self.msIndexedDB || self.OIndexedDB;
-
-indexedDB.deleteDatabase(dbname)
-indexedDB.open(dbname)
-PASS cursorObservers.length is 10000
-PASS anyCollected is true
-PASS successfullyParsed is true
-
-TEST COMPLETE
-
+#EOF
+#EOF

[Radar WebKit Bug Importer]

<rdar://problem/60657081>

[Jacob Uphoff]

Set expectations here: https://bugs.webkit.org/show_bug.cgi?id=209318

[Jacob Uphoff]

I don't think this is worth rolling out the commit because it did fix one of the two tests, and the other test is no longer flaky but it is timing out now.

[Jacob Uphoff]

Looks like this is also timing out on wk1. SO set new expectations here: https://trac.webkit.org/changeset/258742/webkit

[Ryosuke Niwa]

Maybe 10,000 is a bit too high of a number. Maybe try 1000?

[Sihui Liu]

Created attachment 394067 [details]
Patch

[EWS]

Committed r258768: <https://trac.webkit.org/changeset/258768>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 394067 [details].

[Sihui Liu]

Reopening to attach new patch.

[Sihui Liu]

Created attachment 394138 [details]
Patch for landing

[EWS]

Committed r258797: <https://trac.webkit.org/changeset/258797>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 394138 [details].

[Ryosuke Niwa]

Woot! Looks like the flakiness is gone!