Bug 209312 – [LFC][IFC] Bail out when busy looping on partial content

• Status: RESOLVED
• Resolution: FIXED
• Component: Layout and Rendering

[zalan]

<rdar://problem/59954605>

[zalan]

Created attachment 394059 [details]
Patch

[Simon Fraser (smfr)]

Comment on attachment 394059 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=394059&action=review

> Source/WebCore/ChangeLog:3
> +        [LFC][IFC] Bail out when busy looping on partial content

"Avoid infinite loop when..."

> Source/WebCore/ChangeLog:9
> +        Speculative fix to address busy looping/running out of inline run vector capacity at InlineFormattingContext::setDisplayBoxesForLine.

"busy looping" sounds like something that happens over time. Is it really an infinite loop?

> Source/WebCore/layout/inlineformatting/InlineFormattingContext.cpp:162
> +                // "sp<->litcontent" -> overflow length: 10 -> leading partial content length: 10.

Weird comment.

> Source/WebCore/layout/inlineformatting/InlineFormattingContext.cpp:175
> +                    ASSERT_NOT_REACHED();
> +                    // Move over to the next run if we are stuck on this partial content (when the overflow content length remains the same).
> +                    // We certainly lose some content, but we would be busy looping anyway.
> +                    previousLineEnd = PreviousLineEnd { trailingRunIndex, { } };
> +                    layoutRange.start = previousLineEnd->runIndex + 1;

Weird to assert and then run code.

[zalan]

Created attachment 394081 [details]
Patch

[EWS]

Committed r258761: <https://trac.webkit.org/changeset/258761>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 394081 [details].