Upstream a variety of Cocoa-platform HAVE and ENABLE macros
Created attachment 394023 [details] Patch
Created attachment 394024 [details] Patch
Comment on attachment 394024 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=394024&action=review > Source/WTF/wtf/PlatformEnableCocoa.h:269 > + || (PLATFORM(IOS_FAMILY) && __IPHONE_OS_VERSION_MIN_REQUIRED >= 130000) \ Isn't IOS_FAMILY and __IPHONE_OS_VERSION_MIN_REQUIRED a no-no? > Source/WTF/wtf/PlatformEnableCocoa.h:275 > + && ((PLATFORM(IOS_FAMILY) && __IPHONE_OS_VERSION_MIN_REQUIRED >= 130000) \ Ditto.
Created attachment 394027 [details] Patch
(In reply to Andy Estes from comment #3) > Comment on attachment 394024 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=394024&action=review > > > Source/WTF/wtf/PlatformEnableCocoa.h:269 > > + || (PLATFORM(IOS_FAMILY) && __IPHONE_OS_VERSION_MIN_REQUIRED >= 130000) \ > > Isn't IOS_FAMILY and __IPHONE_OS_VERSION_MIN_REQUIRED a no-no? > > > Source/WTF/wtf/PlatformEnableCocoa.h:275 > > + && ((PLATFORM(IOS_FAMILY) && __IPHONE_OS_VERSION_MIN_REQUIRED >= 130000) \ > > Ditto. It sure is!
Created attachment 394029 [details] Patch
Created attachment 394030 [details] Patch
Created attachment 394032 [details] Patch
Created attachment 394034 [details] Patch
Comment on attachment 394034 [details] Patch r=mews
Created attachment 394038 [details] Patch
we'll get there someday
Created attachment 394041 [details] Patch
Created attachment 394045 [details] Patch
Created attachment 394047 [details] Patch
Created attachment 394049 [details] Patch
Committed r258748: <https://trac.webkit.org/changeset/258748>
<rdar://problem/60665104>
Reverted r258748 for reason: This commit broke the Catalina build Committed r258765: <https://trac.webkit.org/changeset/258765>
Committed r258772: <https://trac.webkit.org/changeset/258772>