Bug 209307 - Upstream a variety of Cocoa-platform HAVE and ENABLE macros
Summary: Upstream a variety of Cocoa-platform HAVE and ENABLE macros
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Tim Horton
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2020-03-19 14:18 PDT by Tim Horton
Modified: 2020-03-20 11:31 PDT (History)
15 users (show)

See Also:


Attachments
Patch (6.63 KB, patch)
2020-03-19 14:18 PDT, Tim Horton
no flags Details | Formatted Diff | Diff
Patch (8.59 KB, patch)
2020-03-19 14:51 PDT, Tim Horton
no flags Details | Formatted Diff | Diff
Patch (9.46 KB, patch)
2020-03-19 14:59 PDT, Tim Horton
no flags Details | Formatted Diff | Diff
Patch (9.80 KB, patch)
2020-03-19 15:03 PDT, Tim Horton
no flags Details | Formatted Diff | Diff
Patch (9.95 KB, patch)
2020-03-19 15:04 PDT, Tim Horton
no flags Details | Formatted Diff | Diff
Patch (9.98 KB, patch)
2020-03-19 15:05 PDT, Tim Horton
no flags Details | Formatted Diff | Diff
Patch (9.05 KB, patch)
2020-03-19 15:12 PDT, Tim Horton
no flags Details | Formatted Diff | Diff
Patch (10.09 KB, patch)
2020-03-19 15:41 PDT, Tim Horton
no flags Details | Formatted Diff | Diff
Patch (10.66 KB, patch)
2020-03-19 15:53 PDT, Tim Horton
no flags Details | Formatted Diff | Diff
Patch (11.14 KB, patch)
2020-03-19 16:40 PDT, Tim Horton
no flags Details | Formatted Diff | Diff
Patch (17.68 KB, patch)
2020-03-19 17:08 PDT, Tim Horton
no flags Details | Formatted Diff | Diff
Patch (18.28 KB, patch)
2020-03-19 17:52 PDT, Tim Horton
aestes: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Tim Horton 2020-03-19 14:18:11 PDT
Upstream a variety of Cocoa-platform HAVE and ENABLE macros
Comment 1 Tim Horton 2020-03-19 14:18:54 PDT
Created attachment 394023 [details]
Patch
Comment 2 Tim Horton 2020-03-19 14:51:01 PDT
Created attachment 394024 [details]
Patch
Comment 3 Andy Estes 2020-03-19 14:58:01 PDT
Comment on attachment 394024 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=394024&action=review

> Source/WTF/wtf/PlatformEnableCocoa.h:269
> +        || (PLATFORM(IOS_FAMILY) && __IPHONE_OS_VERSION_MIN_REQUIRED >= 130000) \

Isn't IOS_FAMILY and __IPHONE_OS_VERSION_MIN_REQUIRED a no-no?

> Source/WTF/wtf/PlatformEnableCocoa.h:275
> +    && ((PLATFORM(IOS_FAMILY) && __IPHONE_OS_VERSION_MIN_REQUIRED >= 130000) \

Ditto.
Comment 4 Tim Horton 2020-03-19 14:59:53 PDT
Created attachment 394027 [details]
Patch
Comment 5 Tim Horton 2020-03-19 15:00:41 PDT
(In reply to Andy Estes from comment #3)
> Comment on attachment 394024 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=394024&action=review
> 
> > Source/WTF/wtf/PlatformEnableCocoa.h:269
> > +        || (PLATFORM(IOS_FAMILY) && __IPHONE_OS_VERSION_MIN_REQUIRED >= 130000) \
> 
> Isn't IOS_FAMILY and __IPHONE_OS_VERSION_MIN_REQUIRED a no-no?
> 
> > Source/WTF/wtf/PlatformEnableCocoa.h:275
> > +    && ((PLATFORM(IOS_FAMILY) && __IPHONE_OS_VERSION_MIN_REQUIRED >= 130000) \
> 
> Ditto.

It sure is!
Comment 6 Tim Horton 2020-03-19 15:03:00 PDT
Created attachment 394029 [details]
Patch
Comment 7 Tim Horton 2020-03-19 15:04:40 PDT
Created attachment 394030 [details]
Patch
Comment 8 Tim Horton 2020-03-19 15:05:54 PDT
Created attachment 394032 [details]
Patch
Comment 9 Tim Horton 2020-03-19 15:12:24 PDT
Created attachment 394034 [details]
Patch
Comment 10 Andy Estes 2020-03-19 15:15:13 PDT
Comment on attachment 394034 [details]
Patch

r=mews
Comment 11 Tim Horton 2020-03-19 15:41:47 PDT
Created attachment 394038 [details]
Patch
Comment 12 Tim Horton 2020-03-19 15:42:43 PDT
we'll get there someday
Comment 13 Tim Horton 2020-03-19 15:53:40 PDT
Created attachment 394041 [details]
Patch
Comment 14 Tim Horton 2020-03-19 16:40:14 PDT
Created attachment 394045 [details]
Patch
Comment 15 Tim Horton 2020-03-19 17:08:30 PDT
Created attachment 394047 [details]
Patch
Comment 16 Tim Horton 2020-03-19 17:52:54 PDT
Created attachment 394049 [details]
Patch
Comment 17 Tim Horton 2020-03-19 18:59:07 PDT
Committed r258748: <https://trac.webkit.org/changeset/258748>
Comment 18 Radar WebKit Bug Importer 2020-03-19 19:00:16 PDT
<rdar://problem/60665104>
Comment 19 Jacob Uphoff 2020-03-20 09:30:22 PDT
Reverted r258748 for reason:

This commit broke the Catalina build

Committed r258765: <https://trac.webkit.org/changeset/258765>
Comment 20 Tim Horton 2020-03-20 11:31:40 PDT
Committed r258772: <https://trac.webkit.org/changeset/258772>