Bug 209299 – REGRESSION (r258679): [ Mac ] fast/scrolling/arrow-key-scroll-in-rtl-document.html is failing and timing out

• Status: RESOLVED
• Resolution: FIXED
• Component: Scrolling

[Truitt Savell]

fast/scrolling/arrow-key-scroll-in-rtl-document.html

This test became a frequent flaky failure and timeout after the changes in https://trac.webkit.org/changeset/258679/webkit

I am able to reproduce this issue on 258679 but not 258678 using command:
run-webkit-tests --iterations 2000 --exit-after-n-failures 1 --exit-after-n-crashes-or-timeouts 1 --debug-rwt-logging --no-retry --force --no-build -f  fast/scrolling/arrow-key-scroll-in-rtl-document.html

History:
https://results.webkit.org/?suite=layout-tests&test=fast%2Fscrolling%2Farrow-key-scroll-in-rtl-document.html

Diff:
--- /Volumes/Data/slave/catalina-release-tests-wk2/build/layout-test-results/fast/scrolling/arrow-key-scroll-in-rtl-document-expected.txt
+++ /Volumes/Data/slave/catalina-release-tests-wk2/build/layout-test-results/fast/scrolling/arrow-key-scroll-in-rtl-document-actual.txt
@@ -1 +1 @@
-PASS: scrollLeft is -120
+FAIL: scrollLeft is 0, expected -120

[Radar WebKit Bug Importer]

<rdar://problem/60646111>

[Simon Fraser (smfr)]

I can reproduce.

[Simon Fraser (smfr)]

We don't have WheelEventTestMonitor reasons for the key-scrolling behavior, which is that WebEditorClient::handleKeyboardEvent()calls down into WebPage::scroll() which ends up in FrameView::requestScrollPositionUpdate() and bounces to the scrolling thread, and then back to the main thread.

[Simon Fraser (smfr)]

Created attachment 394154 [details]
Patch

[EWS]

Committed r258805: <https://trac.webkit.org/changeset/258805>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 394154 [details].