Bug 209278 - [GTK][WPE] REGRESSION(r258626): flatpak is used even when WEBKIT_JHBUILD is set
Summary: [GTK][WPE] REGRESSION(r258626): flatpak is used even when WEBKIT_JHBUILD is set
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKitGTK (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords: Gtk, Regression
Depends on:
Blocks:
 
Reported: 2020-03-19 06:31 PDT by Carlos Garcia Campos
Modified: 2020-03-19 07:03 PDT (History)
4 users (show)

See Also:


Attachments
Patch (1.17 KB, patch)
2020-03-19 06:33 PDT, Carlos Garcia Campos
pnormand: review-
Details | Formatted Diff | Diff
Patch (1.19 KB, patch)
2020-03-19 06:58 PDT, Carlos Garcia Campos
pnormand: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Carlos Garcia Campos 2020-03-19 06:31:37 PDT
This happens when using an external jhbuild as I do.
Comment 1 Carlos Garcia Campos 2020-03-19 06:33:39 PDT
Created attachment 393972 [details]
Patch
Comment 2 Philippe Normand 2020-03-19 06:50:06 PDT
Comment on attachment 393972 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=393972&action=review

> Tools/ChangeLog:9
> +        This happens when using an external jhbuild, because shouldUseFlatpak() assumes that no command prefix always
> +        means flatpak.

What's failing exactly?

> Tools/Scripts/webkitdirs.pm:2176
> +    if (defined $ENV{'WEBKIT_JHBUILD'}) {

The env var value should be checked.
Comment 3 Carlos Garcia Campos 2020-03-19 06:58:59 PDT
Created attachment 393973 [details]
Patch
Comment 4 Carlos Garcia Campos 2020-03-19 07:03:57 PDT
Committed r258695: <https://trac.webkit.org/changeset/258695>