RESOLVED FIXED Bug 209278
[GTK][WPE] REGRESSION(r258626): flatpak is used even when WEBKIT_JHBUILD is set 
https://bugs.webkit.org/show_bug.cgi?id=209278
Summary [GTK][WPE] REGRESSION(r258626): flatpak is used even when WEBKIT_JHBUILD is set
Carlos Garcia Campos
Reported 2020-03-19 06:31:37 PDT
This happens when using an external jhbuild as I do.
Attachments
Patch (1.17 KB, patch)
2020-03-19 06:33 PDT, Carlos Garcia Campos 		pnormand: review-
DetailsFormatted DiffDiff
Patch (1.19 KB, patch)
2020-03-19 06:58 PDT, Carlos Garcia Campos 		pnormand: review+
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Carlos Garcia Campos
Comment 1 2020-03-19 06:33:39 PDT
Created attachment 393972 [details] Patch
Philippe Normand
Comment 2 2020-03-19 06:50:06 PDT
Comment on attachment 393972 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=393972&action=review > Tools/ChangeLog:9 > + This happens when using an external jhbuild, because shouldUseFlatpak() assumes that no command prefix always > + means flatpak. What's failing exactly? > Tools/Scripts/webkitdirs.pm:2176 > + if (defined $ENV{'WEBKIT_JHBUILD'}) { The env var value should be checked.
Carlos Garcia Campos
Comment 3 2020-03-19 06:58:59 PDT
Created attachment 393973 [details] Patch
Carlos Garcia Campos
Comment 4 2020-03-19 07:03:57 PDT
Committed r258695: <https://trac.webkit.org/changeset/258695>
Note You need to log in before you can comment on or make changes to this bug.