Bug 20927 - simplify/streamline the code to turn strings into identifiers while parsing
Summary: simplify/streamline the code to turn strings into identifiers while parsing
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: JavaScriptCore (show other bugs)
Version: 528+ (Nightly build)
Hardware: Mac OS X 10.5
: P2 Normal
Assignee: Darin Adler
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2008-09-18 17:09 PDT by Darin Adler
Modified: 2008-09-18 23:32 PDT (History)
0 users

See Also:

Attachments
patch (16.33 KB, patch)
2008-09-18 17:33 PDT, Darin Adler 		no flags Details | Formatted Diff | Diff
patch (9.46 KB, patch)
2008-09-18 17:35 PDT, Darin Adler 		mjs: review+
Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Darin Adler 2008-09-18 17:09:05 PDT 
The code to parse JavaScript currently creates an unnecessary extra UString and then later turns it into an Identifier. This can be streamlined to be simpler, slightly less code, and slightly faster.
Comment 1 Darin Adler 2008-09-18 17:33:59 PDT 
Created attachment 23545 [details]
patch
Comment 2 Darin Adler 2008-09-18 17:35:26 PDT 
Created attachment 23546 [details]
patch
Comment 3 Maciej Stachowiak 2008-09-18 23:24:21 PDT 
Comment on attachment 23546 [details]
patch

r=me
Comment 4 Darin Adler 2008-09-18 23:32:48 PDT 
http://trac.webkit.org/changeset/36660