WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
20927
simplify/streamline the code to turn strings into identifiers while parsing
https://bugs.webkit.org/show_bug.cgi?id=20927
Summary
simplify/streamline the code to turn strings into identifiers while parsing
Darin Adler
Reported
2008-09-18 17:09:05 PDT
The code to parse JavaScript currently creates an unnecessary extra UString and then later turns it into an Identifier. This can be streamlined to be simpler, slightly less code, and slightly faster.
Attachments
patch
(16.33 KB, patch)
2008-09-18 17:33 PDT
,
Darin Adler
no flags
Details
Formatted Diff
Diff
patch
(9.46 KB, patch)
2008-09-18 17:35 PDT
,
Darin Adler
mjs
: review+
Details
Formatted Diff
Diff
Show Obsolete
(1)
View All
Add attachment
proposed patch, testcase, etc.
Darin Adler
Comment 1
2008-09-18 17:33:59 PDT
Created
attachment 23545
[details]
patch
Darin Adler
Comment 2
2008-09-18 17:35:26 PDT
Created
attachment 23546
[details]
patch
Maciej Stachowiak
Comment 3
2008-09-18 23:24:21 PDT
Comment on
attachment 23546
[details]
patch r=me
Darin Adler
Comment 4
2008-09-18 23:32:48 PDT
http://trac.webkit.org/changeset/36660
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug