Currently this parameter is only being passed to the NetworkLoad object in NetworkResourceLoader::startNetworkLoad(). This is not the only way to load resources, so isNavigatingToAppBoundDomain should be updated to reflect that.
<rdar://problem/60552712>
Created attachment 393895 [details] Patch
Comment on attachment 393895 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=393895&action=review > Source/WebKit/Shared/NavigatingToAppBoundDomain.h:42 > +}; We don't need EnumTraits for boolean enum classes. > Source/WebKit/Shared/PolicyDecision.h:104 > template<> struct EnumTraits<WebKit::NavigatedAwayFromAppBoundDomain> { You should be able to remove this one too but that's untreated to this patch.
(In reply to John Wilander from comment #3) > Comment on attachment 393895 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=393895&action=review > > > Source/WebKit/Shared/NavigatingToAppBoundDomain.h:42 > > +}; > > We don't need EnumTraits for boolean enum classes. > > > Source/WebKit/Shared/PolicyDecision.h:104 > > template<> struct EnumTraits<WebKit::NavigatedAwayFromAppBoundDomain> { > > You should be able to remove this one too but that's untreated to this patch. *unrelated
Comment on attachment 393895 [details] Patch I think the overall approach of this patch seems good. I'll check with Chris or Alex to see if they have any other concerns.
I defer to Alex or Youenn here.
Comment on attachment 393895 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=393895&action=review I think the name NavigatingToAppBoundDomain is no longer correct, but I'm ok with it in this patch as long as there's a plan to rename it. r=me > Source/WebKit/Shared/NavigatingToAppBoundDomain.h:36 > +template<> struct EnumTraits<WebKit::NavigatingToAppBoundDomain> { Yes, I agree with John. Please remove this unneeded bit. > Source/WebKit/WebProcess/WebPage/WebFrame.cpp:307 > + webProcess.ensureNetworkProcessConnection().connection().send(Messages::NetworkConnectionToWebProcess::ConvertMainResourceLoadToDownload(mainResourceLoadIdentifier, policyDownloadID, request, response, page()->isNavigatingToAppBoundDomain()), 0); We should probably null check page here and above.
Created attachment 393907 [details] Patch for landing
(In reply to Alex Christensen from comment #7) > Comment on attachment 393895 [details] > Patch > Thanks Alex! This patch has the changes you and John suggested. I will create a radar to rename isNavigatingToAppBoundDomain.
Created attachment 393910 [details] Patch for landing
Committed r258667: <https://trac.webkit.org/changeset/258667> All reviewed patches have been landed. Closing bug and clearing flags on attachment 393910 [details].